From: "David S. Miller" <davem@davemloft.net>
To: christoph@lameter.com
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000
Date: Tue, 17 May 2005 19:57:03 -0700 (PDT) [thread overview]
Message-ID: <20050517.195703.104034854.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.62.0505171941340.21153@graphe.net>
From: Christoph Lameter <christoph@lameter.com>
Subject: Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000
Date: Tue, 17 May 2005 19:52:38 -0700 (PDT)
> > > - txdr->buffer_info = vmalloc(size);
> > > + txdr->buffer_info = kmalloc_node(size, GFP_KERNEL, node);
> >
> > How come that this is safe to do
>
> Because physically contiguous memory is usually better than virtually
> contiguous memory? Any reason that physically contiguous memory will
> break the driver?
The issue is whether size can end up being too large for
kmalloc() to satisfy, whereas vmalloc() would be able to
handle it.
next prev parent reply other threads:[~2005-05-18 2:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 1:56 [PATCH] NUMA aware allocation of transmit and receive buffers for e1000 Christoph Lameter
2005-05-18 2:03 ` Andrew Morton
2005-05-18 2:52 ` Christoph Lameter
2005-05-18 2:57 ` David S. Miller [this message]
2005-05-18 4:27 ` Christoph Lameter
2005-05-18 4:58 ` Andrew Morton
2005-05-18 15:55 ` Ganesh Venkatesan
2005-05-18 20:42 ` Andrew Morton
2005-05-27 21:52 ` [PATCH] e1000: NUMA aware allocation of descriptors V2 Christoph Lameter
2005-05-27 23:25 ` Andrew Morton
2005-05-18 13:19 ` [PATCH] NUMA aware allocation of transmit and receive buffers for e1000 Andi Kleen
2005-05-18 2:05 ` Andi Kleen
2005-05-18 7:49 ` Eric Dumazet
2005-05-18 13:28 ` Andi Kleen
2005-05-27 21:15 ` Christoph Lameter
2005-05-30 9:41 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050517.195703.104034854.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=christoph@lameter.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).