From: Andrew Morton <akpm@osdl.org>
To: Ganesh Venkatesan <ganesh.venkatesan@gmail.com>
Cc: christoph@lameter.com, davem@davemloft.net,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
shai@scalex86.org
Subject: Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000
Date: Wed, 18 May 2005 13:42:50 -0700 [thread overview]
Message-ID: <20050518134250.3ee2703f.akpm@osdl.org> (raw)
In-Reply-To: <5fc59ff305051808558f1ce59@mail.gmail.com>
Ganesh Venkatesan <ganesh.venkatesan@gmail.com> wrote:
>
> On 5/17/05, Andrew Morton <akpm@osdl.org> wrote:
> > I think the e1000 driver is being a bit insane there. I figure that
> Do you mean insane to use vmalloc?
>
> > sizeof(struct e1000_buffer) is 28 on 64-bit, so even with 4k pagesize we'll
> > always succeed in being able to support a 32k/32 = 1024-entry Tx ring.
> >
> > Is there any real-world reason for wanting larger ring sizes than that?
> >
> >
> We have had cases where allocation of 32K of memory (via kmalloc) fails.
>
Are you sure? The current page allocator will infinitely loop until
success for <=32k GFP_KERNEL allocations - the only way it can fail is if
the calling process gets oom-killed.
next prev parent reply other threads:[~2005-05-18 20:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 1:56 [PATCH] NUMA aware allocation of transmit and receive buffers for e1000 Christoph Lameter
2005-05-18 2:03 ` Andrew Morton
2005-05-18 2:52 ` Christoph Lameter
2005-05-18 2:57 ` David S. Miller
2005-05-18 4:27 ` Christoph Lameter
2005-05-18 4:58 ` Andrew Morton
2005-05-18 15:55 ` Ganesh Venkatesan
2005-05-18 20:42 ` Andrew Morton [this message]
2005-05-27 21:52 ` [PATCH] e1000: NUMA aware allocation of descriptors V2 Christoph Lameter
2005-05-27 23:25 ` Andrew Morton
2005-05-18 13:19 ` [PATCH] NUMA aware allocation of transmit and receive buffers for e1000 Andi Kleen
2005-05-18 2:05 ` Andi Kleen
2005-05-18 7:49 ` Eric Dumazet
2005-05-18 13:28 ` Andi Kleen
2005-05-27 21:15 ` Christoph Lameter
2005-05-30 9:41 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050518134250.3ee2703f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=christoph@lameter.com \
--cc=davem@davemloft.net \
--cc=ganesh.venkatesan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).