From: "John W. Linville" <linville@tuxdriver.com>
To: netdev@oss.sgi.com
Cc: jgarzik@pobox.com, Clear.Zhang@uli.com.tw
Subject: [patch 2.6.12-rc4 1/1] tulip: add return to ULI526X clause in tulip_mdio_write
Date: Wed, 18 May 2005 13:41:33 -0400 [thread overview]
Message-ID: <20050518174132.GB16148@tuxdriver.com> (raw)
The 'if' clause for ULI526X in tulip_mdio_write allows for
spin_unlock_irqrestore to be called twice for tp->mii_lock. I believe
this is caused by the unintentional omission of a return at the end
of that clause. This patch adds that return.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
I'm copying Clear Zhang on this. As the author of the patch that
added this code, he should know whether or not my intuitive fix is
actually correct... :-)
drivers/net/tulip/media.c | 1 +
1 files changed, 1 insertion(+)
--- linux-2.6.12-rc4/drivers/net/tulip/media.c.orig 2005-05-18 09:19:07.392564077 -0400
+++ linux-2.6.12-rc4/drivers/net/tulip/media.c 2005-05-18 09:22:47.107779100 -0400
@@ -174,6 +174,7 @@ void tulip_mdio_write(struct net_device
break;
}
spin_unlock_irqrestore(&tp->mii_lock, flags);
+ return;
}
/* Establish sync by sending 32 logic ones. */
--
John W. Linville
linville@tuxdriver.com
next reply other threads:[~2005-05-18 17:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 17:41 John W. Linville [this message]
2005-05-24 4:26 ` [patch 2.6.12-rc4 1/1] tulip: add return to ULI526X clause in tulip_mdio_write Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050518174132.GB16148@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Clear.Zhang@uli.com.tw \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).