From: "David S. Miller" <davem@davemloft.net>
To: niv@us.ibm.com
Cc: herbert@gondor.apana.org.au, jdmason@us.ibm.com,
shemminger@osdl.org, netdev@oss.sgi.com
Subject: Re: [PATCH] Ethernet Bridging: Enable Hardware Checksumming
Date: Thu, 19 May 2005 11:51:41 -0700 (PDT) [thread overview]
Message-ID: <20050519.115141.21926463.davem@davemloft.net> (raw)
In-Reply-To: <428CAC55.4000202@us.ibm.com>
From: Nivedita Singhvi <niv@us.ibm.com>
Date: Thu, 19 May 2005 08:10:13 -0700
> Fair point - though I would argue that devices that
> support SG are much more common now - so optimizing
> for the more common case might be preferable - since
> people using bridging with devices that support
> checksum offload are taking quite a hit when they
> do bridging - perhaps this could be a conditional?
I disagree. Many low costs devices are non-SG still,
there is no reason to penalize them explicitly.
I think instead we should look at ways to propagate
the hardware device features to the bridge. Even if
a bridge is composed of multiple devices, we just
advertise the subset of features actually supported.
next prev parent reply other threads:[~2005-05-19 18:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 23:53 [PATCH] Ethernet Bridging: Enable Hardware Checksumming Jon Mason
2005-05-19 0:03 ` Nivedita Singhvi
2005-05-19 5:00 ` David S. Miller
2005-05-19 15:13 ` Nivedita Singhvi
2005-05-19 20:34 ` Stephen Hemminger
2005-05-19 2:41 ` Herbert Xu
2005-05-19 15:10 ` Nivedita Singhvi
2005-05-19 18:51 ` David S. Miller [this message]
2005-05-19 20:43 ` Nivedita Singhvi
2005-05-19 20:33 ` Stephen Hemminger
2005-05-19 21:48 ` David S. Miller
2005-05-19 23:23 ` Jon Mason
2005-05-19 23:36 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050519.115141.21926463.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jdmason@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=niv@us.ibm.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).