* [PATCH] ipvs: remove extra __ip_vs_conn_put for incoming ICMP
@ 2005-05-14 7:57 Julian Anastasov
2005-05-19 19:30 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julian Anastasov @ 2005-05-14 7:57 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Wensong Zhang
[-- Attachment #1: Type: TEXT/PLAIN, Size: 244 bytes --]
Hello,
Dave, please apply a patch against 2.6.12-rc4
Remove extra __ip_vs_conn_put for incoming ICMP in direct routing
mode. Mark de Vries reports that IPVS connections are not leaked anymore.
Signed-off-by: Julian Anastasov <ja@ssi.bg>
[-- Attachment #2: Fix ICMP xmit --]
[-- Type: TEXT/PLAIN, Size: 403 bytes --]
diff -ur v2.6.12-rc4/linux/net/ipv4/ipvs/ip_vs_xmit.c linux/net/ipv4/ipvs/ip_vs_xmit.c
--- v2.6.12-rc4/linux/net/ipv4/ipvs/ip_vs_xmit.c 2004-08-31 08:09:31.000000000 +0300
+++ linux/net/ipv4/ipvs/ip_vs_xmit.c 2005-05-09 00:31:47.810807232 +0300
@@ -520,7 +520,6 @@
rc = NF_ACCEPT;
/* do not touch skb anymore */
atomic_inc(&cp->in_pkts);
- __ip_vs_conn_put(cp);
goto out;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ipvs: remove extra __ip_vs_conn_put for incoming ICMP
2005-05-14 7:57 [PATCH] ipvs: remove extra __ip_vs_conn_put for incoming ICMP Julian Anastasov
@ 2005-05-19 19:30 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2005-05-19 19:30 UTC (permalink / raw)
To: ja; +Cc: netdev, wensong
From: Julian Anastasov <ja@ssi.bg>
Date: Sat, 14 May 2005 10:57:26 +0300 (EEST)
> Remove extra __ip_vs_conn_put for incoming ICMP in direct routing
> mode. Mark de Vries reports that IPVS connections are not leaked anymore.
>
> Signed-off-by: Julian Anastasov <ja@ssi.bg>
Applied to 2.6.x, thanks for the patch Julian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-19 19:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-14 7:57 [PATCH] ipvs: remove extra __ip_vs_conn_put for incoming ICMP Julian Anastasov
2005-05-19 19:30 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).