From: "David S. Miller" <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: tommy.christensen@tpack.net, chamas@h4.dion.ne.jp, netdev@oss.sgi.com
Subject: Re: assertion (!atomic_read(&sk->sk_rmem_alloc)) failed at net/netlink/af_netlink.c (122)
Date: Thu, 19 May 2005 12:47:16 -0700 (PDT) [thread overview]
Message-ID: <20050519.124716.74565187.davem@davemloft.net> (raw)
In-Reply-To: <20050511222210.GA21280@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 12 May 2005 08:22:10 +1000
> > What about an alternative fix, that avoids even more cloning (where
> > possible)? This resurrects the skb_orphan call that was moved out, last
> > time we had 'shared-skb troubles'. It is practically a no-op in the
> > common case, but still prevents the possible race with recvmsg.
> > (And I have a weakness for one-line-fixes). :-)
>
> Yep this is much better. Thanks Tommy.
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks a lot guys.
next prev parent reply other threads:[~2005-05-19 19:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-10 12:43 assertion (!atomic_read(&sk->sk_rmem_alloc)) failed at net/netlink/af_netlink.c (122) Ken-ichirou MATSUZAWA
2005-05-10 22:07 ` Herbert Xu
2005-05-11 0:58 ` Herbert Xu
2005-05-11 15:20 ` Ken-ichirou MATSUZAWA
2005-05-11 22:17 ` Tommy Christensen
2005-05-11 22:22 ` Herbert Xu
2005-05-19 19:47 ` David S. Miller [this message]
2005-05-11 23:17 ` Herbert Xu
2005-05-12 9:58 ` Tommy Christensen
2005-05-12 10:42 ` Herbert Xu
2005-05-12 10:58 ` Tommy Christensen
2005-05-12 11:07 ` Herbert Xu
2005-05-19 19:49 ` David S. Miller
2005-05-19 21:34 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050519.124716.74565187.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chamas@h4.dion.ne.jp \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
--cc=tommy.christensen@tpack.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).