From: Jon Mason <jdmason@us.ibm.com>
To: "Catalin(ux aka Dino) BOIE" <util@deuroconsult.ro>
Cc: netdev@oss.sgi.com, davem@davemloft.net
Subject: Re: [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming)
Date: Thu, 19 May 2005 11:06:53 -0500 [thread overview]
Message-ID: <200505191106.53136.jdmason@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0505191654400.24043@webhosting.rdsbv.ro>
This patch only enables the features which are common between all of the
bridged devices (at the time of their addition to the bridge). It overlooks
the cases where not all of the adapters have the same features, or where the
user has changed the enablement of a certain feature (via ethtool).
Thanks,
Jon
On Thursday 19 May 2005 10:28 am, Catalin(ux aka Dino) BOIE wrote:
> Hello!
>
> The attached patch, makes the bridge to select features (almost all) only
> if _all_ devices supports them.
> The patch was tested (create a bridge, add an interface, remove the
> interface and always check features flags).
>
> What do you think?
>
> Signed-off-by: Catalin(ux aka Dino) BOIE <catab at umbrella.ro>
> ---
> Catalin(ux aka Dino) BOIE
> catab at deuroconsult.ro
> http://kernel.umbrella.ro/
next prev parent reply other threads:[~2005-05-19 16:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 15:28 [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming) Catalin(ux aka Dino) BOIE
2005-05-19 15:59 ` Nivedita Singhvi
2005-05-19 18:52 ` [PATCH] [BRIDGE] Set features based on slave's ones David S. Miller
2005-05-19 16:06 ` Jon Mason [this message]
2005-05-19 17:22 ` [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming) Catalin(ux aka Dino) BOIE
2005-05-19 17:47 ` Jon Mason
2005-05-19 18:58 ` [PATCH] [BRIDGE] Set features based on slave's ones David S. Miller
2005-05-19 19:07 ` Jon Mason
2005-05-19 19:00 ` [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming) Jon Mason
2005-05-19 19:21 ` [PATCH] [BRIDGE] Set features based on slave's ones David S. Miller
2005-05-19 20:20 ` Jon Mason
2005-05-19 18:53 ` David S. Miller
2005-05-19 20:39 ` [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming) Stephen Hemminger
2005-05-19 21:20 ` Stephen Hemminger
2005-05-19 21:40 ` Jon Mason
2005-05-20 6:07 ` Catalin(ux aka Dino) BOIE
2005-05-20 18:54 ` Jon Mason
2005-05-23 9:39 ` Catalin(ux aka Dino) BOIE
2005-05-23 9:40 ` Catalin(ux aka Dino) BOIE
2005-05-23 19:14 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505191106.53136.jdmason@us.ibm.com \
--to=jdmason@us.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=util@deuroconsult.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).