From: Jon Mason <jdmason@us.ibm.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: util@deuroconsult.ro, netdev@oss.sgi.com
Subject: Re: [PATCH] [BRIDGE] Set features based on slave's ones
Date: Thu, 19 May 2005 14:07:04 -0500 [thread overview]
Message-ID: <200505191407.04650.jdmason@us.ibm.com> (raw)
In-Reply-To: <20050519.115832.111205328.davem@davemloft.net>
On Thursday 19 May 2005 01:58 pm, David S. Miller wrote:
> From: Jon Mason <jdmason@us.ibm.com>
> Date: Thu, 19 May 2005 12:47:55 -0500
>
> > My point is that some features the user might want enabled regardless of
> > whether all devices support them. An example of this is where a system
> > has hardware checksum support for all devices except one. In this case,
> > it would be benefitial to have this device do the checksum in software
> > (via skb_checksum_help() call in dev_queue_xmit()).
>
> If "SG and checksumming is so common these days" as others have
> stated, what you are describing is a totally uncommon scenerio.
Uncommon, yes, but very possible and I am trying to mitigate the performance
effects of this case.
> What
> Catalin is proposing is infinitely better than what we have today.
I completely agree Catalin's patch is better than what we have now. My only
arguement is that there are some cases where it should be augmented to
include additional features.
next prev parent reply other threads:[~2005-05-19 19:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 15:28 [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming) Catalin(ux aka Dino) BOIE
2005-05-19 15:59 ` Nivedita Singhvi
2005-05-19 18:52 ` [PATCH] [BRIDGE] Set features based on slave's ones David S. Miller
2005-05-19 16:06 ` [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming) Jon Mason
2005-05-19 17:22 ` Catalin(ux aka Dino) BOIE
2005-05-19 17:47 ` Jon Mason
2005-05-19 18:58 ` [PATCH] [BRIDGE] Set features based on slave's ones David S. Miller
2005-05-19 19:07 ` Jon Mason [this message]
2005-05-19 19:00 ` [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming) Jon Mason
2005-05-19 19:21 ` [PATCH] [BRIDGE] Set features based on slave's ones David S. Miller
2005-05-19 20:20 ` Jon Mason
2005-05-19 18:53 ` David S. Miller
2005-05-19 20:39 ` [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming) Stephen Hemminger
2005-05-19 21:20 ` Stephen Hemminger
2005-05-19 21:40 ` Jon Mason
2005-05-20 6:07 ` Catalin(ux aka Dino) BOIE
2005-05-20 18:54 ` Jon Mason
2005-05-23 9:39 ` Catalin(ux aka Dino) BOIE
2005-05-23 9:40 ` Catalin(ux aka Dino) BOIE
2005-05-23 19:14 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505191407.04650.jdmason@us.ibm.com \
--to=jdmason@us.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=util@deuroconsult.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).