From: "David S. Miller" <davem@davemloft.net>
To: jgarzik@pobox.com
Cc: mchan@broadcom.com, netdev@oss.sgi.com, ffan@broadcom.com,
lusinsky@broadcom.com
Subject: Re: A new driver for Broadcom bcm5706
Date: Fri, 20 May 2005 16:45:04 -0700 (PDT) [thread overview]
Message-ID: <20050520.164504.31639000.davem@davemloft.net> (raw)
In-Reply-To: <428E72F9.3070404@pobox.com>
From: Jeff Garzik <jgarzik@pobox.com>
Date: Fri, 20 May 2005 19:30:01 -0400
> Sure. What I'm driving at is that a checksum of zero seems to imply
> CHECKSUM_NONE not CHECKSUM_UNNECESSARY. tg3 only does the 0xffff check.
Sure, both ways are fine.
> I am also a bit surprised that, if the actual checksum value is
> available, why not use CHECKSUM_HW like sunhme?
CHECKSUM_HW is for a different calculation than what 5706 and tg3 are
providing here. CHECKSUM_HW is for when the chip provides a raw 2's
complement 16-bit sum starting at a fixed offset from the beginning of
the packet. The network stack then "undoes" or subtracts the header
2's complement checksum from the device provided sum to arrive at the
real checksum result.
5706 and tg3 are actually interpreting the headers and running the
checksum algorithm over the proper parts of the packet headers.
next prev parent reply other threads:[~2005-05-20 23:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-20 17:15 A new driver for Broadcom bcm5706 Michael Chan
2005-05-20 19:42 ` Jeff Garzik
2005-05-20 20:51 ` Jeff Garzik
2005-05-20 21:07 ` Ben Greear
2005-05-20 21:09 ` Jeff Garzik
2005-05-20 20:17 ` Michael Chan
2005-05-20 21:58 ` Ben Greear
2005-05-20 22:28 ` David S. Miller
2005-05-20 23:04 ` Michael Chan
2005-05-21 4:35 ` David S. Miller
2005-05-21 4:36 ` David S. Miller
2005-05-20 23:30 ` Jeff Garzik
2005-05-20 23:45 ` David S. Miller [this message]
2005-05-21 0:01 ` Jeff Garzik
2005-05-20 23:11 ` Michael Chan
2005-05-21 4:28 ` David S. Miller
2005-05-20 21:18 ` Jeff Garzik
2005-05-27 7:41 ` Christoph Hellwig
2005-05-27 15:58 ` Michael Chan
2005-05-27 17:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050520.164504.31639000.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ffan@broadcom.com \
--cc=jgarzik@pobox.com \
--cc=lusinsky@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).