From: Jon Mason <jdmason@us.ibm.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH linux-2.6.12-rc4-mm1] ethtool: Add NETIF_F_HW_CSUM support
Date: Mon, 23 May 2005 16:32:55 -0500 [thread overview]
Message-ID: <200505231632.55476.jdmason@us.ibm.com> (raw)
In-Reply-To: <20050523.142009.74748115.davem@davemloft.net>
On Monday 23 May 2005 04:20 pm, David S. Miller wrote:
> From: Jon Mason <jdmason@us.ibm.com>
> Subject: [PATCH linux-2.6.12-rc4-mm1] ethtool: Add NETIF_F_HW_CSUM support
> Date: Mon, 23 May 2005 16:07:57 -0500
>
> > Added support to ethtool for NETIF_F_HW_CSUM.
> >
> > Signed-off-by: Jon Mason <jdmason@us.ibm.com>
>
> You cannot blindly set these flags, you need to provide
> a method for the driver to override the implementation of
> this method so it can return and error if it cannot provide
> support for this feature.
I am only adding a generic function which gives the ability to use
NETIF_F_HW_CSUM for ethtool tx offload (instead of only using
NETIF_F_IP_CSUM).
If ethtool_set_tx_csum does not point to ethtool_op_set_tx_csum or
ethtool_op_set_tx_hw_csum (or a local driver function) then it will return an
error. Isn't this sufficient (as it is what currently happening), or am I
not sufficently understanding the problem?
Thanks,
Jon
next prev parent reply other threads:[~2005-05-23 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-23 21:07 [PATCH linux-2.6.12-rc4-mm1] ethtool: Add NETIF_F_HW_CSUM support Jon Mason
2005-05-23 21:20 ` David S. Miller
2005-05-23 21:32 ` Jon Mason [this message]
2005-05-23 21:48 ` David S. Miller
2005-05-23 21:53 ` Stephen Hemminger
2005-05-26 23:00 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505231632.55476.jdmason@us.ibm.com \
--to=jdmason@us.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).