Re: [XFRM] Call dst_check() with appropriate cookie

[Herbert Xu <herbert@gondor.apana.org.au>]

On Tue, May 24, 2005 at 05:42:34PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
>
> Probably, it should be better to introduce some upper limit of number of 
> recreation.

Yep, that's why a simple packet blackhole bug became a kernel hang.

In fact, we don't need to retry at all.  If the policy goes dead on us
or if the route becomes invalid after we passed the check in xfrm_lookup,
the packet is dropped anyway.  There is no point in retrying the lookup
here since that only covers the cases where we detect the problem before
the bundle is inserted into the list.

So we should simply return an error instead of retrying.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt