From: Dave Jones <davej@redhat.com>
To: Jiri Benc <jbenc@suse.cz>
Cc: NetDev <netdev@oss.sgi.com>, pavel@suse.cz
Subject: Re: [1-2/6] ipw2100, ipw2200: patches to merge to kernel
Date: Tue, 24 May 2005 13:24:16 -0400 [thread overview]
Message-ID: <20050524172416.GB10479@redhat.com> (raw)
In-Reply-To: <20050524151506.48e5db65@griffin.suse.cz>
On Tue, May 24, 2005 at 03:15:06PM +0200, Jiri Benc wrote:
> Patches to merge the ipw2100 and ipw2200 drivers to the kernel can be
> downloaded from:
> http://jikos.cz/~jbohac/wifi/import-ipw2100.patch
> http://jikos.cz/~jbohac/wifi/import-ipw2200.patch
> (they are too large to post them here)
>
> The ipw2100 patch is just a merge of ipw2100 driver with Pavel Machek's
> cleanup patch.
It contains a number of bogus uses of HZ.
+ IPW_DEBUG_INFO("Command completion failed out after %dms.\n",
+ HOST_COMPLETE_TIMEOUT / (HZ / 100));
..
+ schedule_timeout(HZ / 100);
..
What I don't understand, is that HZ in kernel-code should be 1000
according to <asm/param.h>, though for some reason, I've seen
divide by zeros, and really strange oopses with this code.
It's as if its for some reason, choosing to use the userspace HZ
definition. Hmm, does it need an explicit include of <asm/param.h>
perhaps ?
Dave
next prev parent reply other threads:[~2005-05-24 17:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-24 13:07 [0/5] Improvements to the ieee80211 layer Jiri Benc
2005-05-24 13:10 ` [1/5] ieee80211: cleanup Jiri Benc
2005-05-28 2:43 ` Jeff Garzik
2005-05-24 13:11 ` [2/5] ieee80211: ieee80211_device alignment fix and cleanup Jiri Benc
2005-05-28 3:37 ` Jeff Garzik
2005-05-31 13:30 ` Jiri Benc
2005-05-24 13:12 ` [3/5] netdev: HH_DATA_OFF bugfix Jiri Benc
2005-05-28 3:15 ` Jeff Garzik
2005-05-24 13:12 ` [4/5] ieee80211: ethernet independency Jiri Benc
2005-05-24 13:13 ` [5/5] ieee80211: add sequence numbers Jiri Benc
2005-05-24 13:15 ` [1-2/6] ipw2100, ipw2200: patches to merge to kernel Jiri Benc
2005-05-24 17:24 ` Dave Jones [this message]
2005-05-24 17:56 ` Thomas Graf
2005-05-24 13:16 ` [3/6] ipw2100: fix after "ieee80211: cleanup" Jiri Benc
2005-05-24 13:18 ` [4/6] ipw2100: fix after "ieee80211_device alignment fix" Jiri Benc
2005-05-24 18:58 ` Pavel Machek
2005-05-24 19:18 ` Jirka Bohac
2005-05-24 13:19 ` [5/6] ipw2200: " Jiri Benc
2005-05-24 13:20 ` [6/6] ipw2200: fix after "ieee80211: ethernet independency" Jiri Benc
2005-05-24 18:52 ` [0/5] Improvements to the ieee80211 layer Pavel Machek
2005-05-25 8:29 ` Jirka Bohac
2005-05-25 9:27 ` Pavel Machek
2005-05-25 9:42 ` Jiri Benc
2005-05-25 6:55 ` Zhu Yi
2005-05-25 11:20 ` Jiri Benc
2005-05-26 3:36 ` Zhu Yi
2005-05-28 3:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050524172416.GB10479@redhat.com \
--to=davej@redhat.com \
--cc=jbenc@suse.cz \
--cc=netdev@oss.sgi.com \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).