From: "David S. Miller" <davem@davemloft.net>
To: jdmason@us.ibm.com
Cc: netdev@oss.sgi.com, niv@us.ibm.com, habanero@us.ibm.com
Subject: Re: Interdomain/interpartition communication without a checksum
Date: Wed, 25 May 2005 15:39:43 -0700 (PDT) [thread overview]
Message-ID: <20050525.153943.69020533.davem@davemloft.net> (raw)
In-Reply-To: <20050517163420.GA19251@us.ibm.com>
From: Jon Mason <jdmason@us.ibm.com>
Date: Tue, 17 May 2005 11:34:20 -0500
> --- ../xen-unstable-pristine/linux-2.6.11-xen0/include/linux/skbuff.h 2005-03-02 01:38:38.000000000 -0600
> +++ linux-2.6.11-xen0/include/linux/skbuff.h 2005-05-13 10:43:08.000000000 -0500
> @@ -37,6 +37,10 @@
> #define CHECKSUM_HW 1
> #define CHECKSUM_UNNECESSARY 2
>
> +#define SKB_CLONED 1
> +#define SKB_NOHDR 2
> +#define SKB_FDW_NO_CSUM 4
> +
You create SKB_NOHDR yet do not make use of it to
replace skb->nohdr.
> @@ -603,7 +603,7 @@ int pskb_expand_head(struct sk_buff *skb
> skb->mac.raw += off;
> skb->h.raw += off;
> skb->nh.raw += off;
> - skb->cloned = 0;
> + skb->flags &= SKB_CLONED;
> atomic_set(&skb_shinfo(skb)->dataref, 1);
> return 0;
This does not clear SKB_CLONED, it makes it the only possible
bit set. Clearly this was not your intention.
prev parent reply other threads:[~2005-05-25 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-11 18:35 Interdomain/interpartition communication without a checksum Jon Mason
2005-05-16 20:07 ` David S. Miller
2005-05-17 16:34 ` Jon Mason
2005-05-25 22:39 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050525.153943.69020533.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=habanero@us.ibm.com \
--cc=jdmason@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=niv@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).