From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: [PATCH 2.6] fix deadlock with ip_queue and tcp local input path Date: Thu, 26 May 2005 14:01:57 -0700 (PDT) Message-ID: <20050526.140157.74747743.davem@davemloft.net> References: <20050526142420.GD13114@sunbeam.de.gnumonks.org> <20050526.135229.111208218.davem@davemloft.net> <20050526205831.GL13114@sunbeam.de.gnumonks.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@oss.sgi.com, netfilter-devel@lists.netfilter.org Return-path: To: laforge@netfilter.org In-Reply-To: <20050526205831.GL13114@sunbeam.de.gnumonks.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netdev.vger.kernel.org From: Harald Welte Subject: Re: [PATCH 2.6] fix deadlock with ip_queue and tcp local input path Date: Thu, 26 May 2005 22:58:31 +0200 > On Thu, May 26, 2005 at 01:52:29PM -0700, David S. Miller wrote: > > > > Dave: Please don't apply yet, I want to receive feedback from the > > > netfilter developers first. I'm just Cc'ing netdev in case somebody > > > wants an intermediate fix to fix the problem. > > > > OK. > > Do you have any feedback on why or how bh_lock_sock() might be called in > the problem I've described? I think it has to be a different skb for > the same socket. When we hit a listening socket, and hung off of that listening socket we find a child socket, we bh_lock_sock() the child socket then process the SKB against it instead of the listening socket. Is this the kind of scenerio you are concerned about?