From: Thomas Graf <tgraf@suug.ch>
To: Harald Welte <laforge@gnumonks.org>
Cc: David Miller <davem@davemloft.net>,
Hasso Tepper <hasso@estpak.ee>,
netdev@oss.sgi.com
Subject: Re: primary and secondary ip addresses
Date: Thu, 26 May 2005 20:21:46 +0200 [thread overview]
Message-ID: <20050526182146.GV15391@postel.suug.ch> (raw)
In-Reply-To: <20050526181118.GK13114@sunbeam.de.gnumonks.org>
* Harald Welte <20050526181118.GK13114@sunbeam.de.gnumonks.org> 2005-05-26 20:11
> David, would you consider applying that patch to mainline? I think
> there was concensus on this solution, and it has now received some
> amount of testing by Hasso and me.
I agree, I've been running this patch for 3 weeks now without
any problems. Two comments below.
> @@ -281,6 +289,13 @@
> if (!in_dev->ifa_list)
> inetdev_destroy(in_dev);
> }
> +
> + if (promote && IN_DEV_PROMOTE_SECONDARIES(in_dev)) {
promote can only be !=NULL if promotion is enabled, no?
> + /* not sure if we should send a delete notify first? */
> + promote->ifa_flags &= ~IFA_F_SECONDARY;
> + rtmsg_ifa(RTM_NEWADDR, promote);
This can be improved, however sending a delete/add seems
inappropriate. I've patch prepared to add a change mask
which will give us the proper methods to do this right
but for now this is just fine I guess.
next prev parent reply other threads:[~2005-05-26 18:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <41912F7A.6000408@redhat.com>
[not found] ` <Pine.LNX.4.61.0411100034320.10593@filer.marasystems.com>
2004-12-16 9:28 ` primary and secondary ip addresses Harald Welte
2004-12-16 9:53 ` Hasso Tepper
2004-12-16 10:07 ` Henrik Nordstrom
2004-12-16 11:02 ` Hasso Tepper
2004-12-16 16:02 ` Henrik Nordstrom
2004-12-17 15:10 ` Andrea G Forte
2004-12-17 15:27 ` Henrik Nordstrom
2004-12-17 15:58 ` Andrea G Forte
2004-12-17 16:39 ` Henrik Nordstrom
2004-12-17 17:17 ` Andrea G Forte
2004-12-17 19:17 ` Henrik Nordstrom
2004-12-17 18:03 ` Hasso Tepper
2004-12-17 18:37 ` Martin A. Brown
2004-12-17 18:53 ` Hasso Tepper
2004-12-17 19:25 ` Henrik Nordstrom
2004-12-17 20:55 ` Hasso Tepper
2004-12-17 20:54 ` Andrea G Forte
2004-12-17 19:20 ` David S. Miller
2004-12-17 19:48 ` Henrik Nordstrom
2004-12-19 20:18 ` jamal
2004-12-19 21:41 ` Harald Welte
2004-12-19 22:02 ` Thomas Graf
2004-12-19 22:59 ` jamal
2004-12-19 23:56 ` jamal
2004-12-20 13:55 ` jamal
2004-12-20 14:29 ` Harald Welte
2005-04-12 10:54 ` Harald Welte
2005-05-08 12:31 ` Hasso Tepper
2005-05-26 18:11 ` Harald Welte
2005-05-26 18:21 ` Thomas Graf [this message]
2005-05-26 21:58 ` David S. Miller
2004-12-16 16:48 ` Paul Jakma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050526182146.GV15391@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=hasso@estpak.ee \
--cc=laforge@gnumonks.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).