From: Harald Welte <laforge@netfilter.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com, netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH 2.6] fix deadlock with ip_queue and tcp local input path
Date: Thu, 26 May 2005 22:58:31 +0200 [thread overview]
Message-ID: <20050526205831.GL13114@sunbeam.de.gnumonks.org> (raw)
In-Reply-To: <20050526.135229.111208218.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
On Thu, May 26, 2005 at 01:52:29PM -0700, David S. Miller wrote:
> > Dave: Please don't apply yet, I want to receive feedback from the
> > netfilter developers first. I'm just Cc'ing netdev in case somebody
> > wants an intermediate fix to fix the problem.
>
> OK.
Do you have any feedback on why or how bh_lock_sock() might be called in
the problem I've described? I think it has to be a different skb for
the same socket.
Is my general line of thought correct that we shouldn't traverse the
local input path from sysirq context ?
Thanks.
--
- Harald Welte <laforge@netfilter.org> http://netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-05-26 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 14:24 [PATCH 2.6] fix deadlock with ip_queue and tcp local input path Harald Welte
2005-05-26 20:52 ` David S. Miller
2005-05-26 20:58 ` Harald Welte [this message]
2005-05-26 21:01 ` David S. Miller
2005-05-26 21:38 ` Herbert Xu
2005-05-27 7:37 ` Harald Welte
2005-05-30 18:06 ` Harald Welte
2005-05-30 22:26 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050526205831.GL13114@sunbeam.de.gnumonks.org \
--to=laforge@netfilter.org \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox