netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: "David S. Miller" <davem@davemloft.net>
Cc: werner@almesberger.net, netdev@oss.sgi.com
Subject: [PATCH 2/7] [PKT_SCHED] make dsmark try using pfifo instead of noop while grafting
Date: Fri, 27 May 2005 16:51:36 +0200	[thread overview]
Message-ID: <20050527145136.GT15391@postel.suug.ch> (raw)
In-Reply-To: <20050527145002.GR15391@postel.suug.ch>


Signed-off-by: Thomas Graf <tgraf@suug.ch>

---
commit 0297af53b691b2c14b09f65be7b9e32a43a34319
tree 686339fe0d5a70e263d261324365e65f53cc9880
parent 99ed2eb92cc035b223e2d383446f7f183600ba27
author Thomas Graf <tgraf@suug.ch> Fri, 27 May 2005 14:30:37 +0200
committer Thomas Graf <tgraf@suug.ch> Fri, 27 May 2005 14:30:37 +0200

 net/sched/sch_dsmark.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

Index: net/sched/sch_dsmark.c
===================================================================
--- 127116412eeedf62fcda0acc882500cd981cbab1/net/sched/sch_dsmark.c  (mode:100644)
+++ 686339fe0d5a70e263d261324365e65f53cc9880/net/sched/sch_dsmark.c  (mode:100644)
@@ -73,8 +73,13 @@
 
 	DPRINTK("dsmark_graft(sch %p,[qdisc %p],new %p,old %p)\n",sch,p,new,
 	    old);
-	if (!new)
-		new = &noop_qdisc;
+
+	if (new == NULL) {
+		new = qdisc_create_dflt(sch->dev, &pfifo_qdisc_ops);
+		if (new == NULL)
+			new = &noop_qdisc;
+	}
+
 	sch_tree_lock(sch);
 	*old = xchg(&p->q,new);
 	if (*old)

  parent reply	other threads:[~2005-05-27 14:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-27 14:50 [PATCHSET] dsmark fixes & cleanups Thomas Graf
2005-05-27 14:50 ` [PATCH 1/7] [PKT_SCHED] Fix dsmark to count ignored indices while walking Thomas Graf
2005-05-31 22:20   ` David S. Miller
2005-05-27 14:51 ` Thomas Graf [this message]
2005-05-31 22:20   ` [PATCH 2/7] [PKT_SCHED] make dsmark try using pfifo instead of noop while grafting David S. Miller
2005-05-27 14:52 ` [PATCH 3/7] [PKT_SCHED] Disable dsmark debugging messages by default Thomas Graf
2005-05-31 22:20   ` David S. Miller
2005-05-27 14:52 ` [PATCH 4/7] [RTNETLINK] Add RTA_(PUT|GET) shortcuts for u8, u16, and flag Thomas Graf
2005-05-27 14:53 ` [PATCH 5/7] [PKT_SCHED] Fix dsmark to apply changes consistent Thomas Graf
2005-05-27 14:54 ` [PATCH 6/7] [PKT_SCHED] Make dsmark use the new dumping macros Thomas Graf
2005-05-27 14:56 ` [PATCH 7/7] [PKT_SCHED] Logic simplifications and codingstyle/whitespace cleanups Thomas Graf
2005-05-31 22:30   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050527145136.GT15391@postel.suug.ch \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@oss.sgi.com \
    --cc=werner@almesberger.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).