From: "David S. Miller" <davem@davemloft.net>
To: edgar.iglesias@axis.com
Cc: netdev@oss.sgi.com
Subject: Re: ipv4 ipsec
Date: Tue, 31 May 2005 15:56:42 -0700 (PDT) [thread overview]
Message-ID: <20050531.155642.38710400.davem@davemloft.net> (raw)
In-Reply-To: <20050531224717.GE4068@edgar.se.axis.com>
From: Edgar E Iglesias <edgar.iglesias@axis.com>
Date: Wed, 1 Jun 2005 00:47:17 +0200
> Im not sure this is the correct list for ipsec issues, but shouldn't
> the size check at the bottom of net/ipv4/esp4.c be the other way
> around (2.6.11)?
You are right, good catch. Luckily the size of esp_decap_data
is exactly 20 bytes, so the incorrect test happens to be harmless.
> --- /usr/src/linux-2.6.11-gentoo-r8/net/ipv4/esp4.c 2005-05-11 10:05:03.000000000 +0200
> +++ esp4.c 2005-06-01 00:38:55.000000000 +0200
Please porperly -p1 root your patch so I can apply it, and also
please provide a "Signed-off-by: " line for yourself as well.
It may seem pointless for a one-line patch, but I want to get you
and others into the habit of submitting patches properly in the
future.
next prev parent reply other threads:[~2005-05-31 22:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-31 22:47 ipv4 ipsec Edgar E Iglesias
2005-05-31 22:56 ` David S. Miller [this message]
2005-05-31 23:23 ` Edgar E Iglesias
2005-05-31 23:47 ` David S. Miller
2005-06-01 0:02 ` Edgar E Iglesias
2005-06-01 0:08 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050531.155642.38710400.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edgar.iglesias@axis.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).