From: Christoph Hellwig <hch@lst.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] shaper.c: fix locking
Date: Wed, 1 Jun 2005 07:21:50 +0200 [thread overview]
Message-ID: <20050601052149.GA11935@lst.de> (raw)
In-Reply-To: <20050531.144114.78710204.davem@davemloft.net>
On Tue, May 31, 2005 at 02:41:14PM -0700, David S. Miller wrote:
> From: Christoph Hellwig <hch@lst.de>
> Subject: [PATCH] shaper.c: fix locking
> Date: Fri, 27 May 2005 13:54:50 +0200
>
> > o use a semaphore instead of an opencoded and racy lock
> > o move locking out of shaper_kick and into the callers - most just
> > released the lock before calling shaper_kick
> > o remove in_interrupt() tests. from ->close we can always block, from
> > ->hard_start_xmit and timer context never
>
> Do you really want to use a semaphore for a lock taken
> %99 of the time in software IRQ context, which obviously
> cannot sleep?
I want to change as little as possible from the previous variant ;-)
next prev parent reply other threads:[~2005-06-01 5:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 11:54 [PATCH] shaper.c: fix locking Christoph Hellwig
2005-05-31 21:41 ` David S. Miller
2005-06-01 5:21 ` Christoph Hellwig [this message]
2005-06-02 23:36 ` David S. Miller
2005-06-03 2:36 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050601052149.GA11935@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).