From: Jiri Benc <jbenc@suse.cz>
To: <gwingerde@home.nl>
Cc: <netdev@oss.sgi.com>, <jbohac@suse.cz>
Subject: Re: [PATCH] ieee80211: Update generic definitions to latest specs.
Date: Fri, 3 Jun 2005 11:33:43 +0200 [thread overview]
Message-ID: <20050603113343.55d19cfc@griffin.suse.cz> (raw)
In-Reply-To: <20050602190232.340996282D7@mail.suse.cz>
On Thu, 2 Jun 2005 21:02:24 +0200, gwingerde@home.nl wrote:
> I was thinking about that too, but couldn't find a proper shorter
> version without losing the descriptive meaning.
>
> Do you have any suggestions to shorten them?
Maybe we can lose a bit of descriptiveness and put comments above
definitions instead?
I can imagine names such as WLAN_STATUS_ASSOC_DENIED_NOSPECTRUM,
WLAN_STATUS_ASSOC_DENIED_BAD_POWER,
WLAN_STATUS_ASSOC_DENIED_BAD_SUPPCHANNS, WLAN_REASON_DISASSOC_BAD_POWER,
and so on. Also WLAN_STATUS_ASSOC_DENIED_NOSHORT seems to be acceptable
for me.
More often used identifiers probably could have even shorter name - what
about renaming IEEE80211_FCTL_PROTECTEDFRAME to
IEEE80211_FCTL_PROTECTED?
Thanks,
--
Jiri Benc
SUSE Labs
next parent reply other threads:[~2005-06-03 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050602190232.340996282D7@mail.suse.cz>
2005-06-03 9:33 ` Jiri Benc [this message]
2005-06-04 5:29 ` [PATCH] ieee80211: Update generic definitions to latest specs Jouni Malinen
2005-06-01 20:50 Gertjan van Wingerde
2005-06-01 21:37 ` Stephen Hemminger
2005-06-02 3:48 ` Gertjan van Wingerde
2005-06-02 16:50 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050603113343.55d19cfc@griffin.suse.cz \
--to=jbenc@suse.cz \
--cc=gwingerde@home.nl \
--cc=jbohac@suse.cz \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).