From: Christoph Hellwig <hch@infradead.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Christoph Hellwig <hch@infradead.org>,
"David S. Miller" <davem@davemloft.net>,
James Morris <jmorris@redhat.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
netdev@oss.sgi.com
Subject: Re: [RFC] Replace scatterlist with crypto_frag
Date: Sat, 4 Jun 2005 12:58:53 +0100 [thread overview]
Message-ID: <20050604115853.GA20335@infradead.org> (raw)
In-Reply-To: <20050604112606.GA1799@gondor.apana.org.au>
On Sat, Jun 04, 2005 at 09:26:06PM +1000, Herbert Xu wrote:
> On Sat, Jun 04, 2005 at 12:23:14PM +0100, Christoph Hellwig wrote:
> > On Sat, Jun 04, 2005 at 09:46:23AM +1000, Herbert Xu wrote:
> > > struct crypto_frag {
> > > struct page *page;
> > > u16 offset;
> > > u16 length;
> > > };
> >
> > we have this structure as skb_frag_struct and bio_vec already, care
> > to use the same structure with a generic name for all of them?
>
> I certainly would have no problems merging with skb_frag_struct.
> However, merging with bio_vec would mean that either bio_vec would
> have to drop down to 16-bit counters, or crypto_frag would have to
> move up to 32-bit counters.
the usage of 16bit counters in bio_vec doesn't make sense, and if did
all others would have to move to 32bit aswell (in case we started
supporting page sizes that aren't addressable by 16bits)
next prev parent reply other threads:[~2005-06-04 11:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 23:46 [RFC] Replace scatterlist with crypto_frag Herbert Xu
2005-06-04 0:02 ` Jeff Garzik
2005-06-04 0:42 ` Herbert Xu
2005-06-04 4:39 ` James Morris
2005-06-04 4:51 ` Herbert Xu
2005-06-04 5:23 ` James Morris
2005-06-04 5:33 ` Herbert Xu
2005-06-04 10:00 ` Evgeniy Polyakov
2005-06-04 9:55 ` Evgeniy Polyakov
2005-06-04 9:58 ` Herbert Xu
2005-06-04 10:17 ` Evgeniy Polyakov
2005-06-04 10:22 ` Herbert Xu
2005-06-04 10:29 ` Evgeniy Polyakov
2005-06-04 10:32 ` Herbert Xu
2005-06-04 10:40 ` Evgeniy Polyakov
2005-06-06 22:36 ` David S. Miller
2005-06-04 11:23 ` Christoph Hellwig
2005-06-04 11:26 ` Herbert Xu
2005-06-04 11:58 ` Christoph Hellwig [this message]
2005-06-06 11:59 ` Herbert Xu
2005-06-06 12:09 ` Christoph Hellwig
2005-06-06 12:40 ` Herbert Xu
2005-06-06 13:30 ` Christoph Hellwig
2005-06-06 22:46 ` David S. Miller
2005-06-06 23:04 ` Herbert Xu
2005-06-06 23:09 ` David S. Miller
2005-06-06 23:14 ` Herbert Xu
2005-06-06 23:18 ` David S. Miller
2005-06-06 23:20 ` Herbert Xu
2005-06-06 23:05 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050604115853.GA20335@infradead.org \
--to=hch@infradead.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).