From: "David S. Miller" <davem@davemloft.net>
To: netdev@oss.sgi.com
Cc: herbert@gondor.apana.org.au, jheffner@psc.edu
Subject: [PATCH 4/9]: TCP: The Road to Super TSO
Date: Mon, 06 Jun 2005 21:18:52 -0700 (PDT) [thread overview]
Message-ID: <20050606.211852.55512928.davem@davemloft.net> (raw)
In-Reply-To: <20050606.210846.07641049.davem@davemloft.net>
[TCP]: Move __tcp_data_snd_check into tcp_output.c
It reimplements portions of tcp_snd_check(), so it
we move it to tcp_output.c we can consolidate it's
logic much easier in a later change.
Signed-off-by: David S. Miller <davem@davemloft.net>
bdbf09522de5be3ada129dceaa3ad9da9be078bc (from cba5d690f46699d37df7dc087247d1f7c7155692)
diff --git a/include/net/tcp.h b/include/net/tcp.h
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -945,6 +945,7 @@ extern __u32 cookie_v4_init_sequence(str
/* tcp_output.c */
extern int tcp_write_xmit(struct sock *, int nonagle);
+extern void __tcp_data_snd_check(struct sock *sk, struct sk_buff *skb);
extern void __tcp_push_pending_frames(struct sock *sk, struct tcp_sock *tp,
unsigned cur_mss, int nonagle);
extern int tcp_may_send_now(struct sock *sk, struct tcp_sock *tp);
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3975,16 +3975,6 @@ static inline void tcp_check_space(struc
}
}
-static void __tcp_data_snd_check(struct sock *sk, struct sk_buff *skb)
-{
- struct tcp_sock *tp = tcp_sk(sk);
-
- if (after(TCP_SKB_CB(skb)->end_seq, tp->snd_una + tp->snd_wnd) ||
- tcp_packets_in_flight(tp) >= tp->snd_cwnd ||
- tcp_write_xmit(sk, tp->nonagle))
- tcp_check_probe_timer(sk, tp);
-}
-
static __inline__ void tcp_data_snd_check(struct sock *sk)
{
struct sk_buff *skb = sk->sk_send_head;
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -536,6 +536,16 @@ void __tcp_push_pending_frames(struct so
tcp_cwnd_validate(sk, tp);
}
+void __tcp_data_snd_check(struct sock *sk, struct sk_buff *skb)
+{
+ struct tcp_sock *tp = tcp_sk(sk);
+
+ if (after(TCP_SKB_CB(skb)->end_seq, tp->snd_una + tp->snd_wnd) ||
+ tcp_packets_in_flight(tp) >= tp->snd_cwnd ||
+ tcp_write_xmit(sk, tp->nonagle))
+ tcp_check_probe_timer(sk, tp);
+}
+
int tcp_may_send_now(struct sock *sk, struct tcp_sock *tp)
{
struct sk_buff *skb = sk->sk_send_head;
next prev parent reply other threads:[~2005-06-07 4:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-07 4:08 [PATCH 0/9]: TCP: The Road to Super TSO David S. Miller
2005-06-07 4:16 ` [PATCH 1/9]: " David S. Miller
2005-06-07 4:17 ` [PATCH 2/9]: " David S. Miller
2005-06-07 4:17 ` [PATCH 3/9]: " David S. Miller
2005-06-07 4:18 ` David S. Miller [this message]
2005-06-07 4:19 ` [PATCH 5/9]: " David S. Miller
2005-06-07 4:20 ` [PATCH 6/9]: " David S. Miller
2005-06-07 4:21 ` [PATCH 7/9]: " David S. Miller
2005-06-07 4:22 ` [PATCH 8/9]: " David S. Miller
2005-06-07 4:23 ` [PATCH 9/9]: " David S. Miller
2005-06-07 4:56 ` [PATCH 0/9]: " Stephen Hemminger
2005-06-07 5:51 ` David S. Miller
2005-06-08 21:40 ` John Heffner
2005-06-08 21:49 ` David S. Miller
2005-06-08 22:10 ` Herbert Xu
2005-06-09 4:55 ` Leonid Grossman
2005-06-08 22:19 ` Leonid Grossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050606.211852.55512928.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jheffner@psc.edu \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).