* [patch 2.6.12-rc6] 3c59x: remove superfluous vortex_debug test from boomerang_start_xmit
@ 2005-06-10 14:27 John W. Linville
2005-06-13 3:31 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2005-06-10 14:27 UTC (permalink / raw)
To: netdev, linux-kernel; +Cc: akpm, jgarzik
Remove the superfluous test of "if (vortex_debug > 3)" inside the
"if (vortex_debug > 6)" clause early in boomerang_start_xmit.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
I stumbled across this while looking at something else...
drivers/net/3c59x.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
--- a/drivers/net/3c59x.c
+++ b/drivers/net/3c59x.c
@@ -2202,9 +2202,8 @@ boomerang_start_xmit(struct sk_buff *skb
if (vortex_debug > 6) {
printk(KERN_DEBUG "boomerang_start_xmit()\n");
- if (vortex_debug > 3)
- printk(KERN_DEBUG "%s: Trying to send a packet, Tx index %d.\n",
- dev->name, vp->cur_tx);
+ printk(KERN_DEBUG "%s: Trying to send a packet, Tx index %d.\n",
+ dev->name, vp->cur_tx);
}
if (vp->cur_tx - vp->dirty_tx >= TX_RING_SIZE) {
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2.6.12-rc6] 3c59x: remove superfluous vortex_debug test from boomerang_start_xmit
2005-06-10 14:27 [patch 2.6.12-rc6] 3c59x: remove superfluous vortex_debug test from boomerang_start_xmit John W. Linville
@ 2005-06-13 3:31 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2005-06-13 3:31 UTC (permalink / raw)
To: John W. Linville; +Cc: netdev, linux-kernel, akpm
John W. Linville wrote:
> Remove the superfluous test of "if (vortex_debug > 3)" inside the
> "if (vortex_debug > 6)" clause early in boomerang_start_xmit.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
ACK (I presume akpm will send this one upstream)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-06-13 3:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-10 14:27 [patch 2.6.12-rc6] 3c59x: remove superfluous vortex_debug test from boomerang_start_xmit John W. Linville
2005-06-13 3:31 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).