From: "David S. Miller" <davem@davemloft.net>
To: ak@muc.de
Cc: gnuwind@gmail.com, casavan@sgi.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: Is kernel 2.6.11 adjust tcp_max_syn_backlog incorrectly?
Date: Mon, 13 Jun 2005 14:24:18 -0700 (PDT) [thread overview]
Message-ID: <20050613.142418.08323454.davem@davemloft.net> (raw)
In-Reply-To: <m11x79dwcb.fsf@muc.de>
From: Andi Kleen <ak@muc.de>
Date: Sat, 11 Jun 2005 12:25:08 +0200
> Yes, there were some changes here when it was converted to a common
> function for all hash tables (alloc_large_system_hash - the function
> with the argument list from hell). Anyways, here's a quick fix.
>
> DaveM for your consideration.
>
> Adjust TCP mem order check to new alloc_large_system_hash
>
> Signed-off-by: Andi Kleen <ak@suse.de>
I just reread those NUMA changes, and they changed the heuristics
for sizing things at the same time as moving over to the
alloc_large_system_hash() change.
The change was to move from (21 - PAGE_SHIFT) and (23 - PAGE_SHIFT)
to (25 - PAGE_SHIFT) and (27 - PAGE_SHIFT) respectively.
This is the part of the NUMA TCP changes that made the sysctl setting
behavior differ.
Andi's patch is the least intrusive fix for 2.6.12, so I will
apply it. But longer term these heuristics need to be revisited
as a whole.
prev parent reply other threads:[~2005-06-13 21:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <75052be7050606070691c302d@mail.gmail.com>
[not found] ` <75052be705060607106a6c0882@mail.gmail.com>
2005-06-11 10:25 ` Is kernel 2.6.11 adjust tcp_max_syn_backlog incorrectly? Andi Kleen
2005-06-13 21:24 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050613.142418.08323454.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ak@muc.de \
--cc=casavan@sgi.com \
--cc=gnuwind@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).