Netdev List
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: juhl-lkml@dif.dk
Cc: yoshfuji@linux-ipv6.org, kuznet@ms2.inr.ac.ru,
	jmorris@redhat.com, waltje@uWalt.NL.Mugnet.ORG.sgi.com,
	ross.biro@gmail.com, netdev@oss.sgi.com,
	linux-kernel@vger.kernel.org
Subject: Re: [-mm PATCH] signed vs unsigned cleanup in net/ipv4/raw.c
Date: Wed, 15 Jun 2005 12:16:28 -0700 (PDT)	[thread overview]
Message-ID: <20050615.121628.112622743.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.62.0506152101350.3842@dragon.hyggekrogen.localhost>


I'm not merging this thing, at least no all at once.

"size_t" vs. "unsigned int" vs. "int" length comparisons are where all
the security problems come from in the protocol stack

Therefore you should make a seperate patch for each type
change you make and explain why it doesn't add some regression
in terms of signedness issues.

  reply	other threads:[~2005-06-15 19:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-15 19:13 [-mm PATCH] signed vs unsigned cleanup in net/ipv4/raw.c Jesper Juhl
2005-06-15 19:16 ` David S. Miller [this message]
2005-06-15 19:28   ` Jesper Juhl
2005-06-15 19:58     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050615.121628.112622743.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jmorris@redhat.com \
    --cc=juhl-lkml@dif.dk \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=ross.biro@gmail.com \
    --cc=waltje@uWalt.NL.Mugnet.ORG.sgi.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox