From: "David S. Miller" <davem@davemloft.net>
To: juhl-lkml@dif.dk
Cc: yoshfuji@linux-ipv6.org, kuznet@ms2.inr.ac.ru,
jmorris@redhat.com, ross.biro@gmail.com, netdev@oss.sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [-mm PATCH][4/4] net: signed vs unsigned cleanup in net/ipv4/raw.c
Date: Wed, 15 Jun 2005 14:29:53 -0700 (PDT) [thread overview]
Message-ID: <20050615.142953.59469324.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.62.0506152316060.3842@dragon.hyggekrogen.localhost>
From: Jesper Juhl <juhl-lkml@dif.dk>
Date: Wed, 15 Jun 2005 23:32:22 +0200 (CEST)
> - if (length >= sizeof(*iph) && iph->ihl * 4 <= length) {
> + if (length >= sizeof(*iph) && (size_t)(iph->ihl * 4) <= length) {
Would changing the "4" into "4U" kill this warning just the same?
I think I'd prefer that.
next prev parent reply other threads:[~2005-06-15 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-15 21:32 [-mm PATCH][4/4] net: signed vs unsigned cleanup in net/ipv4/raw.c Jesper Juhl
2005-06-15 21:29 ` David S. Miller [this message]
2005-06-15 21:40 ` Jesper Juhl
2005-06-15 21:41 ` David S. Miller
2005-06-15 21:48 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050615.142953.59469324.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@redhat.com \
--cc=juhl-lkml@dif.dk \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=ross.biro@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox