From: "David S. Miller" <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@oss.sgi.com, mchan@broadcom.com
Subject: Re: [PATCH]: Tigon3 new NAPI locking v2
Date: Thu, 16 Jun 2005 13:04:17 -0700 (PDT) [thread overview]
Message-ID: <20050616.130417.78707215.davem@davemloft.net> (raw)
In-Reply-To: <20050616130453.GA23682@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH]: Tigon3 new NAPI locking v2
Date: Thu, 16 Jun 2005 23:04:53 +1000
> On Thu, Jun 16, 2005 at 09:59:45PM +1000, herbert wrote:
> >
> > Actually, why don't we utilise the existing synchronize_irq mechanism?
> > Here is what we could do.
>
> Oops, I should've left the smp_mb() in tg3_irq_quiesce since
> synchronize_irq isn't a memory barrier.
Wow, that's a very cool idea. :-)
In fact, I think it will eliminate some (but definitely not all) of
the races that the new locking code has.
When you posted the patch with the atomic bitop added to the interrupt
handler, I was going to tell you that the whole idea was to make it
near zero cost to the interrupt fast path. :)
prev parent reply other threads:[~2005-06-16 20:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 19:25 [PATCH]: Tigon3 new NAPI locking v2 David S. Miller
2005-06-03 20:23 ` Jeff Garzik
2005-06-06 6:01 ` David S. Miller
2005-06-07 10:11 ` Greg Banks
2005-06-21 20:21 ` David S. Miller
2005-06-16 11:37 ` Herbert Xu
2005-06-16 11:59 ` Herbert Xu
2005-06-16 13:04 ` Herbert Xu
2005-06-16 20:04 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050616.130417.78707215.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mchan@broadcom.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).