From: Arnd Bergmann <arnd@arndb.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Utz Bacher <utz.bacher@de.ibm.com>,
linuxppc64-dev@ozlabs.org, Jeff Garzik <jgarzik@pobox.com>,
Jens Osterkamp <Jens.Osterkamp@de.ibm.com>
Subject: Re: [PATCH] net: add driver for the NIC on Cell Blades
Date: Wed, 29 Jun 2005 02:38:58 +0200 [thread overview]
Message-ID: <200506290238.59231.arnd@arndb.de> (raw)
In-Reply-To: <1119966799.3175.32.camel@laptopd505.fenrus.org>
On Dinsdag 28 Juni 2005 15:53, Arjan van de Ven wrote:
>
> > +static void
> > +spider_net_rx_irq_off(struct spider_net_card *card)
> > +{
> > + u32 regvalue;
> > + unsigned long flags;
> > +
> > + spin_lock_irqsave(&card->intmask_lock, flags);
> > + regvalue = spider_net_read_reg(card, SPIDER_NET_GHIINT0MSK);
> > + regvalue &= ~SPIDER_NET_RXINT;
> > + spider_net_write_reg(card, SPIDER_NET_GHIINT0MSK, regvalue);
> > + spin_unlock_irqrestore(&card->intmask_lock, flags);
> > +}
>
> I think you have a PCI posting bug here....
Could you be more specific? My guess would be that the 'sync' in writel
takes care of this. Should there be an extra mmiowb() in here or are
you referring to some other problem?
Arnd <><
next prev parent reply other threads:[~2005-06-29 0:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 13:28 [PATCH] net: add driver for the NIC on Cell Blades Arnd Bergmann
2005-06-28 13:47 ` [PATCH] net: add missing include to netdevice.h Arnd Bergmann
2005-06-28 22:59 ` David S. Miller
2005-06-28 13:53 ` [PATCH] net: add driver for the NIC on Cell Blades Arjan van de Ven
2005-06-29 0:38 ` Arnd Bergmann [this message]
2005-06-29 7:32 ` Arjan van de Ven
2005-06-29 12:55 ` Arnd Bergmann
2005-06-29 23:48 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506290238.59231.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Jens.Osterkamp@de.ibm.com \
--cc=arjan@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=utz.bacher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).