From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: [PATCH 1/2] updates for [nf|ct]netlink and event API Date: Thu, 30 Jun 2005 14:03:02 +0200 Message-ID: <20050630120302.GI16076@postel.suug.ch> References: <42C03F2E.30706@eurodev.net> <42C0806E.3010400@trash.net> <20050628071308.GE13239@sunbeam.de.gnumonks.org> <42C1747A.3010703@trash.net> <42C2F2DF.7070301@eurodev.net> <42C2FC14.80609@trash.net> <42C33E33.7090908@eurodev.net> <42C34445.9020709@trash.net> <20050630014901.GH16076@postel.suug.ch> <42C350A1.1030602@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Harald Welte , netdev@vger.kernel.org, Jamal Hadi Salim , Netfilter Development Mailinglist , Pablo Neira Return-path: To: Patrick McHardy Content-Disposition: inline In-Reply-To: <42C350A1.1030602@trash.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netdev.vger.kernel.org * Patrick McHardy <42C350A1.1030602@trash.net> 2005-06-30 03:53 > Thomas Graf wrote: > > At some point we should introduce a "generic" attribute > > architecture for all netlink families. The connector > > stuff will need it as well, so maybe the time has come > > to actually do it. > > I agree, most of the macros are just copied without modification > anyway. One more thing I would like to change is the excessive > use of RTA_PUT with structures on the stack. Using __RTA_PUT > and putting together these structures in-place would be much > nicer. nfnetlink has copied this part of rtnetlink. Good point, after all, I think structs have been used too often and we now suffer from backwards compatbility issues. The points likely to be argueable are things like trim responsibility in the error handling, i.e. delegate it down to the function which also created the header or trim on every level. Other than that the whole thing should be pretty straight forward. What do you think about naming it nlattr?