* [2.6 patch] fix IP_FIB_HASH kconfig warning
@ 2005-07-03 22:20 Adrian Bunk
2005-07-04 18:27 ` Roman Zippel
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2005-07-03 22:20 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel, zippel
[ This time with a subject... ]
This patch fixes the following kconfig warning:
net/ipv4/Kconfig:92:warning: defaults for choice values not supported
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
I've Cc'ed Roman because I might have missed a more elegant solution.
--- linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig.old 2005-07-02 20:07:25.000000000 +0200
+++ linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig 2005-07-02 20:13:05.000000000 +0200
@@ -58,8 +58,9 @@
depends on IP_ADVANCED_ROUTER
default IP_FIB_HASH
-config IP_FIB_HASH
+config ASK_IP_FIB_HASH
bool "FIB_HASH"
+ select IP_FIB_HASH
---help---
Current FIB is very proven and good enough for most users.
@@ -84,12 +85,9 @@
endchoice
-# If the user does not enable advanced routing, he gets the safe
-# default of the fib-hash algorithm.
config IP_FIB_HASH
bool
- depends on !IP_ADVANCED_ROUTER
- default y
+ default y if !IP_ADVANCED_ROUTER
config IP_MULTIPLE_TABLES
bool "IP: policy routing"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] fix IP_FIB_HASH kconfig warning
2005-07-03 22:20 [2.6 patch] fix IP_FIB_HASH kconfig warning Adrian Bunk
@ 2005-07-04 18:27 ` Roman Zippel
2005-07-09 3:07 ` Adrian Bunk
0 siblings, 1 reply; 4+ messages in thread
From: Roman Zippel @ 2005-07-04 18:27 UTC (permalink / raw)
To: Adrian Bunk; +Cc: netdev, linux-kernel
Hi,
On Mon, 4 Jul 2005, Adrian Bunk wrote:
> --- linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig.old 2005-07-02 20:07:25.000000000 +0200
> +++ linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig 2005-07-02 20:13:05.000000000 +0200
> @@ -58,8 +58,9 @@
> depends on IP_ADVANCED_ROUTER
> default IP_FIB_HASH
>
> -config IP_FIB_HASH
> +config ASK_IP_FIB_HASH
> bool "FIB_HASH"
> + select IP_FIB_HASH
> ---help---
> Current FIB is very proven and good enough for most users.
>
> @@ -84,12 +85,9 @@
>
> endchoice
>
> -# If the user does not enable advanced routing, he gets the safe
> -# default of the fib-hash algorithm.
> config IP_FIB_HASH
> bool
> - depends on !IP_ADVANCED_ROUTER
> - default y
> + default y if !IP_ADVANCED_ROUTER
>
> config IP_MULTIPLE_TABLES
> bool "IP: policy routing"
I'd prefer to do it without select.
config IP_FIB_HASH
def_bool ASK_IP_FIB_HASH || !IP_ADVANCED_ROUTER
bye, Roman
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] fix IP_FIB_HASH kconfig warning
2005-07-04 18:27 ` Roman Zippel
@ 2005-07-09 3:07 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-07-09 3:07 UTC (permalink / raw)
To: Roman Zippel; +Cc: netdev, linux-kernel
On Mon, Jul 04, 2005 at 08:27:56PM +0200, Roman Zippel wrote:
>...
> config IP_FIB_HASH
> def_bool ASK_IP_FIB_HASH || !IP_ADVANCED_ROUTER
An updated patch is below.
> bye, Roman
cu
Adrian
<-- snip -->
This patch fixes the following kconfig warning:
net/ipv4/Kconfig:92:warning: defaults for choice values not supported
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.13-rc2-mm1-modular/net/ipv4/Kconfig.old 2005-07-08 23:55:31.000000000 +0200
+++ linux-2.6.13-rc2-mm1-modular/net/ipv4/Kconfig 2005-07-08 23:56:23.000000000 +0200
@@ -56,9 +56,9 @@
choice
prompt "Choose IP: FIB lookup algorithm (choose FIB_HASH if unsure)"
depends on IP_ADVANCED_ROUTER
- default IP_FIB_HASH
+ default ASK_IP_FIB_HASH
-config IP_FIB_HASH
+config ASK_IP_FIB_HASH
bool "FIB_HASH"
---help---
Current FIB is very proven and good enough for most users.
@@ -84,12 +84,8 @@
endchoice
-# If the user does not enable advanced routing, he gets the safe
-# default of the fib-hash algorithm.
config IP_FIB_HASH
- bool
- depends on !IP_ADVANCED_ROUTER
- default y
+ def_bool ASK_IP_FIB_HASH || !IP_ADVANCED_ROUTER
config IP_MULTIPLE_TABLES
bool "IP: policy routing"
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] fix IP_FIB_HASH kconfig warning
@ 2005-07-15 21:35 Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-07-15 21:35 UTC (permalink / raw)
To: Andrew Morton; +Cc: Roman Zippel, netdev, linux-kernel
This patch fixes the following kconfig warning:
net/ipv4/Kconfig:92:warning: defaults for choice values not supported
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 9 Jul 2005
--- linux-2.6.13-rc2-mm1-modular/net/ipv4/Kconfig.old 2005-07-08 23:55:31.000000000 +0200
+++ linux-2.6.13-rc2-mm1-modular/net/ipv4/Kconfig 2005-07-08 23:56:23.000000000 +0200
@@ -56,9 +56,9 @@
choice
prompt "Choose IP: FIB lookup algorithm (choose FIB_HASH if unsure)"
depends on IP_ADVANCED_ROUTER
- default IP_FIB_HASH
+ default ASK_IP_FIB_HASH
-config IP_FIB_HASH
+config ASK_IP_FIB_HASH
bool "FIB_HASH"
---help---
Current FIB is very proven and good enough for most users.
@@ -84,12 +84,8 @@
endchoice
-# If the user does not enable advanced routing, he gets the safe
-# default of the fib-hash algorithm.
config IP_FIB_HASH
- bool
- depends on !IP_ADVANCED_ROUTER
- default y
+ def_bool ASK_IP_FIB_HASH || !IP_ADVANCED_ROUTER
config IP_MULTIPLE_TABLES
bool "IP: policy routing"
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-07-15 21:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-03 22:20 [2.6 patch] fix IP_FIB_HASH kconfig warning Adrian Bunk
2005-07-04 18:27 ` Roman Zippel
2005-07-09 3:07 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-07-15 21:35 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).