From: Pavel Machek <pavel@suse.cz>
To: Zhu Yi <yi.zhu@intel.com>
Cc: jketreno@linux.intel.com, netdev@oss.sgi.com, jbohac@suse.cz,
jbenc@suse.cz
Subject: Re: ipw2100: more cleanups
Date: Mon, 4 Jul 2005 09:05:06 +0200 [thread overview]
Message-ID: <20050704070506.GA15370@elf.ucw.cz> (raw)
In-Reply-To: <1120456146.27821.85.camel@debian.sh.intel.com>
Hi!
> > More cleanups (relative to ipw2100-1.1.0 version). Highlights include
> > removing of two printk wrappers.
>
> [snip]
>
> > -static DEVICE_ATTR(bssinfo, S_IRUGO, show_bssinfo, NULL);
>
> Any special reason to remove these driver sysfs entries?
Umm, yes, they should not be needed and we do not want to maintain
them in /sys forever. /sys should be "one value per file", and
definitely not for debugging stuff like this. (See debugfs)
Anyway I think I did drop that patch from newer cleanup attempts.
Pavel
--
teflon -- maybe it is a trademark, but it should not be.
prev parent reply other threads:[~2005-07-04 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-13 21:40 ipw2100: more cleanups Pavel Machek
2005-07-04 5:49 ` Zhu Yi
2005-07-04 7:05 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050704070506.GA15370@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=jbenc@suse.cz \
--cc=jbohac@suse.cz \
--cc=jketreno@linux.intel.com \
--cc=netdev@oss.sgi.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).