From: "David S. Miller" <davem@davemloft.net>
To: hch@infradead.org
Cc: raghavendra.koushik@neterion.com, jgarzik@pobox.com,
netdev@oss.sgi.com, ravinandan.arakali@neterion.com,
leonid.grossman@neterion.com, rapuru.sriram@neterion.com
Subject: Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements
Date: Tue, 12 Jul 2005 13:34:04 -0700 (PDT) [thread overview]
Message-ID: <20050712.133404.52118192.davem@davemloft.net> (raw)
In-Reply-To: <20050712202754.GA10768@infradead.org>
From: Christoph Hellwig <hch@infradead.org>
Date: Tue, 12 Jul 2005 21:27:54 +0100
> > +/* Enable 2 buffer mode by default for SGI system */
> > +#ifdef CONFIG_IA64_SGI_SN2
> > +#define CONFIG_2BUFF_MODE
> > +#endif
>
> this enabled it only on kernel that are built to only run on SN2
> hardware, which is completely useless in practice. Besides that defining
> a CONFIG_ symbol from source files is a big no-go.
Yes, do this in the Kconfig file instead.
next prev parent reply other threads:[~2005-07-12 20:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-07 22:27 [PATCH 2.6.12.1 5/12] S2io: Performance improvements raghavendra.koushik
2005-07-07 23:15 ` Arthur Kepner
2005-07-08 1:06 ` Raghavendra Koushik
2005-07-08 3:00 ` David S. Miller
2005-07-08 3:08 ` Jeff Garzik
2005-07-08 15:31 ` Arthur Kepner
2005-07-08 18:16 ` Raghavendra Koushik
2005-07-08 18:17 ` Ravinandan Arakali
2005-07-12 20:27 ` Christoph Hellwig
2005-07-12 20:34 ` David S. Miller [this message]
2005-07-12 21:00 ` Ravinandan Arakali
2005-07-12 21:04 ` David S. Miller
2005-07-12 21:07 ` Christoph Hellwig
2005-07-12 21:26 ` Andi Kleen
2005-07-12 21:54 ` Ravinandan Arakali
2005-07-29 16:37 ` Ravinandan Arakali
2005-07-31 14:05 ` Christoph Hellwig
2005-08-02 23:13 ` Ravinandan Arakali
2005-08-02 23:26 ` 'Christoph Hellwig'
2005-07-12 20:56 ` Leonid Grossman
-- strict thread matches above, loose matches on Subject: below --
2005-08-03 12:48 Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050712.133404.52118192.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=leonid.grossman@neterion.com \
--cc=netdev@oss.sgi.com \
--cc=raghavendra.koushik@neterion.com \
--cc=rapuru.sriram@neterion.com \
--cc=ravinandan.arakali@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).