From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: [PATCH] reduce netfilte sk_buff enlargement Date: Wed, 20 Jul 2005 11:43:58 -0700 (PDT) Message-ID: <20050720.114358.85414044.davem@davemloft.net> References: <20050717220451.GB13434@rama.risq.ericsson.ca> <20050718.203145.105430424.davem@davemloft.net> <20050720132305.GA4077@rama> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, marcel@holtmann.org, netfilter-devel@lists.netfilter.org, wensong@linux-vs.org Return-path: To: laforge@netfilter.org In-Reply-To: <20050720132305.GA4077@rama> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netdev.vger.kernel.org From: Harald Welte Date: Wed, 20 Jul 2005 09:23:05 -0400 > On Mon, Jul 18, 2005 at 08:31:45PM -0700, David S. Miller wrote: > > From: Harald Welte > > Date: Mon, 18 Jul 2005 00:04:51 +0200 > > > > > The only real in-tree user of nfcache was IPVS, who only needs a single > > > bit. Unfortunately I couldn't find some other free bit in sk_buff to > > > stuff that bit into, so I introduced a separate field for them. Maybe > > > the IPVS guys can resolve that to further save space. > > > > I think we must resolve this one before 2.6.14 goes out, which > > gives us a lot of time, but for now I'll eat that one-bit member. > > Well, I hope IPVS people will take care of this. I don't really know > that code too well... Ok, I might take a look at this myself. > > > Initially I wanted to shrink pkt_type to three bits (PACKET_HOST and > > > alike are only 6 values defined), but unfortunately the bluetooth code > > > overloads pkt_type :( > > > > This also must be cured somehow, that really isn't a clean nor nice > > usage of this field. > > I just ran into Marcel Holtmann earlier today. He thinks moving that > data into the cb is fine, though he has to double-check that. > > He also said that he really only needs 5 bits, so even if the current > pkt_type overloading would persist, we could probably shrink it to make > space for the IPVS bit. Ok, sounds great.