From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: [2.6 patch] NETCONSOLE must depend on INET Date: Tue, 26 Jul 2005 16:32:02 -0700 (PDT) Message-ID: <20050726.163202.119887768.davem@davemloft.net> References: <20050719182919.GA5531@stusta.de> <20050719.140104.68160812.davem@davemloft.net> <20050726232043.GB7425@waste.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: bunk@stusta.de, jgarzik@pobox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: To: mpm@selenic.com In-Reply-To: <20050726232043.GB7425@waste.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Matt Mackall Date: Tue, 26 Jul 2005 16:20:43 -0700 > This problem also exists in PKTGEN. And this fix is incorrect as > neither is dependent on the IP part of the networking stack in any > substantive way. The right fix is to make inet_aton available outside > of CONFIG_INET (preferred) or making private copies of inet_aton. Adrian posted a fix, you whine, that's why Adrian's fix went in :-) More seriously, please submit a version of whatever you believe to be the more correct fix so it can be reviewed and integrated.