From: Eugene Surovegin <ebs@ebshome.net>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: jgarzik@pobox.com, netdev@oss.sgi.com, wfarnsworth@mvista.com
Subject: Re: [PATCH] emac: add bamboo support
Date: Wed, 27 Jul 2005 23:59:44 -0700 [thread overview]
Message-ID: <20050728065943.GA16041@gate.ebshome.net> (raw)
In-Reply-To: <20050727104247.C1114@cox.net>
On Wed, Jul 27, 2005 at 10:42:47AM -0700, Matt Porter wrote:
> Adds support for the Bamboo board phys in the EMAC driver.
> Please apply.
>
> Signed-off-by: Wade Farnsworth <wfarnsworth@mvista.com>
> Signed-off-by: Matt Porter <mporter@kernel.crashing.org>
>
[snip]
> +#ifdef CONFIG_BAMBOO
> +static int ac104_init(struct mii_phy *phy)
> +{
> + /*
> + * SW2 on the Bamboo is used for ethernet configuration and is accessed
> + * via the CONFIG2 register in the FPGA. If the ANEG pin is set,
> + * overwrite the supported features with the settings in SW2.
> + */
I wonder, how this SW2 works. Is it just a way to tell software not to
use autoneg and force some settings, or it disables autoneg on hw
level (I'm kinda doubt that)?
If this is just some board specific configuration option which doesn't
affect this PHY directly, let's drop this stuff completely and always
use autoneg, if user wants to force something - he should ethtool.
--
Eugene
next prev parent reply other threads:[~2005-07-28 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-27 17:42 [PATCH] emac: add bamboo support Matt Porter
2005-07-28 6:59 ` Eugene Surovegin [this message]
2005-07-28 17:25 ` Wade Farnsworth
2005-07-28 17:31 ` Eugene Surovegin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050728065943.GA16041@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=jgarzik@pobox.com \
--cc=mporter@kernel.crashing.org \
--cc=netdev@oss.sgi.com \
--cc=wfarnsworth@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).