From: Jouni Malinen <jkmaline@cc.hut.fi>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
hostap@shmoo.com, jgarzik@pobox.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [-mm patch] include/net/ieee80211.h must #include <linux/wireless.h>
Date: Sat, 30 Jul 2005 19:24:22 -0700 [thread overview]
Message-ID: <20050731022422.GH8195@jm.kir.nu> (raw)
In-Reply-To: <20050727195100.GA29092@stusta.de>
On Wed, Jul 27, 2005 at 09:51:00PM +0200, Adrian Bunk wrote:
> gcc found an (although perhaps harmless) bug:
>
> CC net/ieee80211/ieee80211_crypt.o
> In file included from net/ieee80211/ieee80211_crypt.c:21:
> include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
> +++ linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h 2005-07-22 18:38:10.000000000 +0200
> +#include <linux/wireless.h>
> #if WIRELESS_EXT < 17
> #define IW_QUAL_QUAL_INVALID 0x10
Wouldn't the proper fix be to just remove this backwards compatibility
code since WIRELESS_EXT is actually 18 in this tree anyway.. Is there
valid need to keep this header file compatible with older kernel
versions?
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2005-07-31 2:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-27 19:51 [-mm patch] include/net/ieee80211.h must #include <linux/wireless.h> Adrian Bunk
2005-07-31 2:24 ` Jouni Malinen [this message]
2005-07-31 3:13 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2005-07-22 21:39 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050731022422.GH8195@jm.kir.nu \
--to=jkmaline@cc.hut.fi \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=hostap@shmoo.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).