From: Daniel Phillips <phillips@istop.com>
To: Mateusz Berezecki <mateuszb@gmail.com>
Cc: kernel-mentors@selenic.com, netdev <netdev@vger.kernel.org>
Subject: Re: argh... ;/
Date: Sat, 6 Aug 2005 02:41:30 +1000 [thread overview]
Message-ID: <200508060241.30507.phillips@istop.com> (raw)
In-Reply-To: <42F2D749.70306@gmail.com>
On Friday 05 August 2005 13:04, Mateusz Berezecki wrote:
> I accidentaly posted the patches as MIME attachments... its 5:03 am here
> already. Sorry guys.
> I can resubmit if you want. I just dont want do that now and not trash
> your mailboxes
Does anybody still care if patches are posted as attachments, particularly for
review as opposed to submission?
I will make the standard comment about C99 // comments, but add that I use
them myself to mean "this comment will definitely be gone by the time it gets
officially submitted", in other words, work in progress.
Heroic work! And nicely lindented at least. Some long lines, but in the same
kinds of places I write them myself.
Only commenting on the form, not substance. Best of luck. I have one of
these things here so when you declare it ready I will try it.
Regards,
Daniel
next prev parent reply other threads:[~2005-08-05 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-05 3:04 argh... ;/ Mateusz Berezecki
2005-08-05 16:41 ` Daniel Phillips [this message]
2005-08-05 17:20 ` John W. Linville
2005-08-05 17:45 ` Jeff Garzik
2005-08-05 17:49 ` Dave Jones
2005-08-05 18:56 ` Daniel Phillips
2005-08-12 5:36 ` Chris Wedgwood
2005-08-12 11:35 ` Ralf Baechle
2005-08-12 11:44 ` John W. Linville
2005-08-12 14:22 ` Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508060241.30507.phillips@istop.com \
--to=phillips@istop.com \
--cc=kernel-mentors@selenic.com \
--cc=mateuszb@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).