From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Phillips Subject: Re: argh... ;/ Date: Sat, 6 Aug 2005 02:41:30 +1000 Message-ID: <200508060241.30507.phillips@istop.com> References: <42F2D749.70306@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Cc: kernel-mentors@selenic.com, netdev Return-path: To: Mateusz Berezecki In-Reply-To: <42F2D749.70306@gmail.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-mentors-bounces@selenic.com Errors-To: kernel-mentors-bounces@selenic.com List-Id: netdev.vger.kernel.org On Friday 05 August 2005 13:04, Mateusz Berezecki wrote: > I accidentaly posted the patches as MIME attachments... its 5:03 am here > already. Sorry guys. > I can resubmit if you want. I just dont want do that now and not trash > your mailboxes Does anybody still care if patches are posted as attachments, particularly for review as opposed to submission? I will make the standard comment about C99 // comments, but add that I use them myself to mean "this comment will definitely be gone by the time it gets officially submitted", in other words, work in progress. Heroic work! And nicely lindented at least. Some long lines, but in the same kinds of places I write them myself. Only commenting on the form, not substance. Best of luck. I have one of these things here so when you declare it ready I will try it. Regards, Daniel