From: "David S. Miller" <davem@davemloft.net>
To: halr@voltaire.com
Cc: netdev@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH] sockaddr_ll change for IPoIB interface
Date: Thu, 11 Aug 2005 12:49:16 -0700 (PDT) [thread overview]
Message-ID: <20050811.124916.77057824.davem@davemloft.net> (raw)
In-Reply-To: <1123786117.4403.5835.camel@hal.voltaire.com>
From: Hal Rosenstock <halr@voltaire.com>
Date: 11 Aug 2005 14:48:37 -0400
> The patch below is to accomodate IPoIB link layer address in the
> sockaddr_ll struct so that user space can send and receive IPoIB link
> later packets. Unfortunately, IPoIB has 20 bytes LL addresses rather
> than the 8 byte MAC addresses (or under) used by other LLs.
Two problems. 1) it's a really ugly IPoIB specific hack to extend the
sockaddr_ll structure, it won't work for anything else without adding
more special tests to that af_packet.c code and 2) you inproperly
rooted your patch, so we get stuff like this:
> --- af_packet.c.orig 2005-06-29 19:00:53.000000000 -0400
> +++ af_packet.c 2005-08-05 13:28:49.000000000 -0400
Please find another way to extend the structure.
That's why I didn't respond, this patch was too ugly for words
so it went to the bottom of my prioritized list of things to
do.
next prev parent reply other threads:[~2005-08-11 19:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 18:48 [PATCH] sockaddr_ll change for IPoIB interface Hal Rosenstock
2005-08-11 19:49 ` David S. Miller [this message]
2005-09-10 17:25 ` [PATCH] af_packet: Allow for > 8 byte hardware addresses Eric W. Biederman
2005-09-12 21:13 ` David S. Miller
2005-09-12 22:13 ` Eric W. Biederman
2005-09-12 22:45 ` David S. Miller
2005-09-20 17:17 ` Eric W. Biederman
2005-09-21 7:11 ` David S. Miller
2005-09-20 17:18 ` [PATCH] [NET] socket.c: zero socket addresses before use Eric W. Biederman
2005-09-21 7:13 ` David S. Miller
2005-09-21 13:48 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050811.124916.77057824.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=halr@voltaire.com \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).