From: "David S. Miller" <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org,
netdev@axxeo.de, laforge@gnumonks.org
Subject: Re: [PATCH 2/2] fix NF_QUEUE_NR() macro
Date: Thu, 11 Aug 2005 15:43:11 -0700 (PDT) [thread overview]
Message-ID: <20050811.154311.71554197.davem@davemloft.net> (raw)
In-Reply-To: <E1E3Kt5-0006jy-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 12 Aug 2005 07:46:55 +1000
> Actually, these two versions are different. & is higher than | so
> Harald's version is actually
>
> #define NF_QUEUE_NR(x) (((x << NF_VERDICT_QBITS) & NF_VERDICT_QMASK) | NF_QUEUE)
>
> Which is it?
It's the former that is the intended version.
I put Harald's patch in as-is, if people want to pretty it
up please do so with a follow-on patch but I really don't
think it matters :-)
next prev parent reply other threads:[~2005-08-11 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 7:13 [PATCH 2/2] fix NF_QUEUE_NR() macro Harald Welte
2005-08-11 14:31 ` Ingo Oeser
2005-08-11 19:26 ` Harald Welte
2005-08-11 21:46 ` Herbert Xu
2005-08-11 22:40 ` Harald Welte
2005-08-11 22:43 ` David S. Miller [this message]
2005-08-11 22:31 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050811.154311.71554197.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=laforge@gnumonks.org \
--cc=netdev@axxeo.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).