From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: Possible race with br_del_if() Date: Thu, 18 Aug 2005 17:23:23 -0500 Message-ID: <20050818222323.GI10593@us.ibm.com> References: <20050818214036.GH10593@us.ibm.com> <20050818151202.6fe6ded4@dxpl.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@oss.sgi.com Return-path: To: Stephen Hemminger Content-Disposition: inline In-Reply-To: <20050818151202.6fe6ded4@dxpl.pdx.osdl.net> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org * Stephen Hemminger [2005-08-18 17:11]: > On Thu, 18 Aug 2005 16:40:36 -0500 > Ryan Harper wrote: > > > Hello, > > > > I've encountered several oops when adding and removing interfaces from > > bridges while using Xen. Most of the details are available [1]here. > > The short of it is the following sequence: > > Doesn't the mutex in RTNL work right? or are you calling > routines with out asserting it? unregister_netdevice asserts RTNL, add_del_if() in br_ioctl.c doesn't seem to do so. I don't see it down dev_get_by_index() path either. It looks like any caller of add_del_if() isn't asserting RTNL. The two callers I see are: br_dev_ioctl() in br_ioctl.c old_dev_ioctl() in br_ioctl.c -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com