* 2.6.13-rc6-mm1: drivers/net/s2io.c: compile error with gcc 4.0
[not found] <20050819043331.7bc1f9a9.akpm@osdl.org>
@ 2005-08-19 15:02 ` Adrian Bunk
2005-08-19 17:28 ` 2.6.13-rc6-mm1: too many 'ipv4_table' variables Adrian Bunk
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2005-08-19 15:02 UTC (permalink / raw)
To: Andrew Morton, Raghavendra Koushik, jgarzik; +Cc: linux-kernel, netdev
On Fri, Aug 19, 2005 at 04:33:31AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.13-rc5-mm1:
>...
> -git-netdev-chelsio.patch
> -git-netdev-e100.patch
> -git-netdev-sis190.patch
> -git-netdev-smc91x-eeprom.patch
> -git-netdev-ieee80211-wifi.patch
> -git-netdev-upstream.patch
> +git-netdev-all.patch
>
> And a consolidated netdev tree
>...
This patch causes the following compile error with gcc 4.0:
<-- snip -->
...
CC drivers/net/s2io.o
In file included from drivers/net/s2io.c:65:
drivers/net/s2io.h: In function 'readq':
drivers/net/s2io.h:765: error: invalid lvalue in assignment
drivers/net/s2io.h:766: error: invalid lvalue in assignment
drivers/net/s2io.c: In function 'init_shared_mem':
drivers/net/s2io.c:541: warning: cast from pointer to integer of different size
drivers/net/s2io.c:544: warning: cast to pointer from integer of different size
drivers/net/s2io.c:550: warning: cast from pointer to integer of different size
drivers/net/s2io.c:553: warning: cast to pointer from integer of different size
make[2]: *** [drivers/net/s2io.o] Error 1
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* 2.6.13-rc6-mm1: too many 'ipv4_table' variables
[not found] <20050819043331.7bc1f9a9.akpm@osdl.org>
2005-08-19 15:02 ` 2.6.13-rc6-mm1: drivers/net/s2io.c: compile error with gcc 4.0 Adrian Bunk
@ 2005-08-19 17:28 ` Adrian Bunk
2005-08-20 0:20 ` 2.6.13-rc6-mm1: why is PHYLIB a user-visible option? Adrian Bunk
2005-08-20 19:03 ` [-mm patch] net/core/sysctl_net_core.c: fix PROC_FS=n compile Adrian Bunk
3 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2005-08-19 17:28 UTC (permalink / raw)
To: Andrew Morton, netdev; +Cc: linux-kernel
On Fri, Aug 19, 2005 at 04:33:31AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.13-rc5-mm1:
>...
> git-net.patch
>...
> Subsystem trees
>...
It seems there are too many different 'ipv4_table' variables:
<-- snip -->
...
CC net/ipv4/ipvs/ip_vs_ctl.o
net/ipv4/ipvs/ip_vs_ctl.c:1601: error: static declaration of 'ipv4_table' follows non-static declaration
include/net/ip.h:376: error: previous declaration of 'ipv4_table' was here
make[3]: *** [net/ipv4/ipvs/ip_vs_ctl.o] Error 1
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* 2.6.13-rc6-mm1: why is PHYLIB a user-visible option?
[not found] <20050819043331.7bc1f9a9.akpm@osdl.org>
2005-08-19 15:02 ` 2.6.13-rc6-mm1: drivers/net/s2io.c: compile error with gcc 4.0 Adrian Bunk
2005-08-19 17:28 ` 2.6.13-rc6-mm1: too many 'ipv4_table' variables Adrian Bunk
@ 2005-08-20 0:20 ` Adrian Bunk
2005-08-20 0:29 ` Jeff Garzik
2005-08-20 19:03 ` [-mm patch] net/core/sysctl_net_core.c: fix PROC_FS=n compile Adrian Bunk
3 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-08-20 0:20 UTC (permalink / raw)
To: Andrew Morton, jgarzik; +Cc: linux-kernel, netdev
Is there any reason why PHYLIB is a user-visible option?
As far as I understand it, PHYLIB and the MII PHY device drivers are an
internal library drivers should start to use roughly similar to MII.
But in this case, the options shouldn't be user-visible.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* [-mm patch] net/core/sysctl_net_core.c: fix PROC_FS=n compile
[not found] <20050819043331.7bc1f9a9.akpm@osdl.org>
` (2 preceding siblings ...)
2005-08-20 0:20 ` 2.6.13-rc6-mm1: why is PHYLIB a user-visible option? Adrian Bunk
@ 2005-08-20 19:03 ` Adrian Bunk
2005-08-21 0:14 ` David S. Miller
3 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-08-20 19:03 UTC (permalink / raw)
To: Andrew Morton, davem; +Cc: linux-kernel, netdev
On Fri, Aug 19, 2005 at 04:33:31AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.13-rc5-mm1:
>...
> git-net.patch
>...
> Subsystem trees
>...
This breaks the compilation with CONFIG_PROC_FS=n:
<-- snip -->
...
CC net/core/sysctl_net_core.o
net/core/sysctl_net_core.c:50: error: 'sysctl_wmem_default' undeclared here (not in a function)
net/core/sysctl_net_core.c:58: error: 'sysctl_rmem_default' undeclared here (not in a function)
make[2]: *** [net/core/sysctl_net_core.o] Error 1
<-- snip -->
The fix is simple.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.13-rc6-mm1-full/include/net/sock.h.old 2005-08-20 15:39:23.000000000 +0200
+++ linux-2.6.13-rc6-mm1-full/include/net/sock.h 2005-08-20 15:39:39.000000000 +0200
@@ -1372,9 +1372,7 @@
extern int sysctl_optmem_max;
#endif
-#ifdef CONFIG_PROC_FS
extern __u32 sysctl_wmem_default;
extern __u32 sysctl_rmem_default;
-#endif
#endif /* _SOCK_H */
^ permalink raw reply [flat|nested] 6+ messages in thread