From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: [PATCH] Fix socket bitop damage Date: Mon, 22 Aug 2005 13:21:34 +0200 Message-ID: <20050822112134.GF17371@postel.suug.ch> References: <20050822110218.GA7514@linux-mips.org> <20050822111436.GE17371@postel.suug.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev@linux-mips.org, linux-hams@vger.kernel.org Return-path: To: Ralf Baechle Content-Disposition: inline In-Reply-To: <20050822111436.GE17371@postel.suug.ch> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org * Thomas Graf <20050822111436.GE17371@postel.suug.ch> 2005-08-22 13:14 > * Ralf Baechle <20050822110218.GA7514@linux-mips.org> 2005-08-22 12:02 > > The socket flag cleanups that went into 2.6.12-rc1 are basically oring > > the flags of an old socket into the socket just being created. > > Unfortunately that one was just initialized by sock_init_data(), so already > > has SOCK_ZAPPED set. As the result zapped sockets are created and all > > incoming connection will fail due to this bug which again was carefully > > replicated to at least AX.25, NET/ROM or ROSE. > > I'm probably to one to blame here but I don't get the point yet. Never mind, I got it, sk->sk_flags may be be != 0.