From: Francois Romieu <romieu@fr.zoreil.com>
To: netdev@vger.kernel.org
Cc: pascal.chapperon@wanadoo.fr, lars.vahlenberg@mandator.com,
Alexey Dobriyan <adobriyan@gmail.com>,
apatard@mandriva.com, jgarzik@pobox.com, akpm@osdl.org
Subject: [patch 2.6.13-git3 1/5] sis190: unmask the link change events
Date: Sat, 3 Sep 2005 00:54:25 +0200 [thread overview]
Message-ID: <20050902225425.GB25687@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20050902225224.GA25687@electric-eye.fr.zoreil.com>
link changes reporting does not work when the driver masks its irq event
Signed-off-by: Arnaud Patard <apatard@mandriva.com>
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
diff -puN a/drivers/net/sis190.c~sis190-170 b/drivers/net/sis190.c
--- a/drivers/net/sis190.c~sis190-170 2005-09-02 23:27:18.621147267 +0200
+++ b/drivers/net/sis190.c 2005-09-02 23:27:18.643143712 +0200
@@ -360,7 +360,7 @@ MODULE_VERSION(DRV_VERSION);
MODULE_LICENSE("GPL");
static const u32 sis190_intr_mask =
- RxQEmpty | RxQInt | TxQ1Int | TxQ0Int | RxHalt | TxHalt;
+ RxQEmpty | RxQInt | TxQ1Int | TxQ0Int | RxHalt | TxHalt | LinkChange;
/*
* Maximum number of multicast addresses to filter (vs. Rx-all-multicast).
@@ -923,6 +923,7 @@ static void sis190_phy_task(void * data)
BMSR_ANEGCOMPLETE)) {
net_link(tp, KERN_WARNING "%s: PHY reset until link up.\n",
dev->name);
+ netif_carrier_off(dev);
mdio_write(ioaddr, phy_id, MII_BMCR, val | BMCR_RESET);
mod_timer(&tp->timer, jiffies + SIS190_PHY_TIMEOUT);
} else {
_
next parent reply other threads:[~2005-09-02 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050902225224.GA25687@electric-eye.fr.zoreil.com>
2005-09-02 22:54 ` Francois Romieu [this message]
2005-09-02 22:55 ` [patch 2.6.13-git3 2/5] sis190: recent chipsets from SiS include a RGMII Francois Romieu
2005-09-02 22:56 ` [patch 2.6.13-git3 3/5] sis190: make 10Mbps the default when handling the StationControl register Francois Romieu
2005-09-02 22:56 ` [patch 2.6.13-git3 4/5] sis190: RGMII Tx internal delay fiddling Francois Romieu
2005-09-02 22:57 ` [patch 2.6.13-git3 5/5] sis190: basic sis191 support Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050902225425.GB25687@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=apatard@mandriva.com \
--cc=jgarzik@pobox.com \
--cc=lars.vahlenberg@mandator.com \
--cc=netdev@vger.kernel.org \
--cc=pascal.chapperon@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox