From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [patch 2.6.13 2/2] 3c59x: add option for using memory-mapped PCI I/O resources
Date: Tue, 6 Sep 2005 14:04:14 -0700 [thread overview]
Message-ID: <20050906140414.40b65253.akpm@osdl.org> (raw)
In-Reply-To: <20050906205429.GA19319@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
>
> On Tue, Sep 06, 2005 at 04:44:00PM -0400, John W. Linville wrote:
> > Add module option to enable 3c59x driver to use memory-mapped PCI I/O
> > resources. This may improve performance for those devices so equipped.
> >
> > Add "use_mmio=1" to the 3c59x module options in order to enable this
> > functionality.
>
> I'm not sure a module option makes sense for this setting, except maybe
> as a debugging aid. You should rather have a flag in the PCI IDs private
> data that can be used to enable mmio for those cards that support it.
I guess it's OK for the initial testing. Plus we should make the new
feature default to "on" during initial public testing. I'll make that
change.
next prev parent reply other threads:[~2005-09-06 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 20:41 [patch 2.6.13 1/2] 3c59x: convert to use of pci_iomap API John W. Linville
2005-09-06 20:44 ` [patch 2.6.13 2/2] 3c59x: add option for using memory-mapped PCI I/O resources John W. Linville
2005-09-06 20:54 ` Christoph Hellwig
2005-09-06 21:04 ` Andrew Morton [this message]
[not found] ` <20050906220922.GA26003@tuxdriver.com>
2005-09-06 22:15 ` Andrew Morton
2005-09-06 22:57 ` John W. Linville
2005-09-06 23:13 ` Andrew Morton
2005-09-12 14:48 ` [patch 2.6.13] 3c59x: enable use of memory-mapped PCI I/O John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050906140414.40b65253.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).