From: "John W. Linville" <linville@tuxdriver.com>
To: Tommy Christensen <tommy.christensen@tpack.net>
Cc: Bogdan Costescu <Bogdan.Costescu@iwr.uni-heidelberg.de>,
Jeff Garzik <jgarzik@pobox.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Netdev List <netdev@vger.kernel.org>,
nhorman@tuxdriver.com
Subject: Re: [PATCH] 3c59x: read current link status from phy
Date: Thu, 8 Sep 2005 21:08:18 -0400 [thread overview]
Message-ID: <20050909010816.GA28653@tuxdriver.com> (raw)
In-Reply-To: <4320BD96.3060307@tpack.net>
On Fri, Sep 09, 2005 at 12:39:18AM +0200, Tommy Christensen wrote:
> --- linux-2.6.13-git8/drivers/net/3c59x.c-orig Fri Sep 9 00:05:49 2005
> +++ linux-2.6.13-git8/drivers/net/3c59x.c Fri Sep 9 00:13:55 2005
> @@ -1889,7 +1889,9 @@ vortex_timer(unsigned long data)
> {
> spin_lock_bh(&vp->lock);
> mii_status = mdio_read(dev, vp->phys[0], 1);
> - mii_status = mdio_read(dev, vp->phys[0], 1);
> + if (!(mii_status & BMSR_LSTATUS))
> + /* Re-read to get actual link status */
> + mii_status = mdio_read(dev, vp->phys[0], 1);
> ok = 1;
> if (vortex_debug > 2)
> printk(KERN_DEBUG "%s: MII transceiver has status %4.4x.\n",
Any chance you could re-diff this to apply on top of the patch posted
earlier today by Neil Horman?
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2005-09-09 1:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200509080125.j881PcL9015847@hera.kernel.org>
2005-09-08 1:49 ` [PATCH] 3c59x: read current link status from phy Jeff Garzik
2005-09-08 11:58 ` Bogdan Costescu
2005-09-08 13:05 ` Tommy Christensen
2005-09-08 13:35 ` Bogdan Costescu
2005-09-08 14:42 ` Tommy Christensen
2005-09-08 15:42 ` Bogdan Costescu
2005-09-08 18:56 ` Andy Fleming
2005-09-09 10:10 ` Bogdan Costescu
2005-09-09 18:08 ` Andy Fleming
2005-09-08 22:39 ` Tommy Christensen
2005-09-08 22:41 ` Andrew Morton
2005-09-08 23:12 ` Tommy Christensen
2005-09-09 0:01 ` Jeff Garzik
2005-09-09 1:08 ` John W. Linville [this message]
2005-09-09 7:34 ` Tommy Christensen
2005-09-09 7:44 ` Andrew Morton
2005-09-09 11:35 ` Neil Horman
2005-09-08 14:13 ` [PATCH] 3c59x: cleanup of mdio_read routines to use MII_* macros in include/linux/mii.h Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050909010816.GA28653@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Bogdan.Costescu@iwr.uni-heidelberg.de \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=tommy.christensen@tpack.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).