* [PATCH 5/12] Add descriptions to constants
@ 2005-09-11 22:19 Ralf Baechle DL5RB
2005-09-12 16:41 ` Ingo Oeser
0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle DL5RB @ 2005-09-11 22:19 UTC (permalink / raw)
To: David S. Miller, netdev, linux-hams
Comment the names used for the AX.25 state machine.
Signed-off-by: Ralf Baechle DL5RB <ralf@linux-mips.org>
include/net/ax25.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
Index: linux-cvs/include/net/ax25.h
===================================================================
--- linux-cvs.orig/include/net/ax25.h
+++ linux-cvs/include/net/ax25.h
@@ -97,11 +97,11 @@
/* Define Link State constants. */
enum {
- AX25_STATE_0,
- AX25_STATE_1,
- AX25_STATE_2,
- AX25_STATE_3,
- AX25_STATE_4
+ AX25_STATE_0, /* Listening */
+ AX25_STATE_1, /* SABM sent */
+ AX25_STATE_2, /* DISC sent */
+ AX25_STATE_3, /* Established */
+ AX25_STATE_4 /* Recovery */
};
#define AX25_MODULUS 8 /* Standard AX.25 modulus */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 5/12] Add descriptions to constants
2005-09-11 22:19 [PATCH 5/12] Add descriptions to constants Ralf Baechle DL5RB
@ 2005-09-12 16:41 ` Ingo Oeser
2005-09-12 16:50 ` Ralf Baechle
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Oeser @ 2005-09-12 16:41 UTC (permalink / raw)
To: Ralf Baechle DL5RB; +Cc: David S. Miller, netdev, linux-hams
Hi Ralf,
Ralf Baechle DL5RB wrote:
> Comment the names used for the AX.25 state machine.
What about making it even more useful by aliasing the enum elements?
> Signed-off-by: Ralf Baechle DL5RB <ralf@linux-mips.org>
>
> include/net/ax25.h | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> Index: linux-cvs/include/net/ax25.h
> ===================================================================
> --- linux-cvs.orig/include/net/ax25.h
> +++ linux-cvs/include/net/ax25.h
> @@ -97,11 +97,11 @@
> /* Define Link State constants. */
>
> enum {
> - AX25_STATE_0,
> - AX25_STATE_1,
> - AX25_STATE_2,
> - AX25_STATE_3,
> - AX25_STATE_4
> + AX25_STATE_0, /* Listening */
+ AX25_STATE_LISTENING = AX25_STATE_0,
> + AX25_STATE_1, /* SABM sent */
+ AX25_STATE_SABM_SENT = AX25_STATE_1,
> + AX25_STATE_2, /* DISC sent */
+ AX25_STATE_DISC_SENT = AX25_STATE_2,
> + AX25_STATE_3, /* Established */
+ AX25_STATE_ESTABLISHED = AX25_STATE_3,
> + AX25_STATE_4 /* Recovery */
+ AX25_STATE_RECOVERY = AX25_STATE_4,
> };
That would not break backward compatibility and now the state machine can be
self explanatory :-)
Regards
Ingo Oeser
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 5/12] Add descriptions to constants
2005-09-12 16:41 ` Ingo Oeser
@ 2005-09-12 16:50 ` Ralf Baechle
0 siblings, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2005-09-12 16:50 UTC (permalink / raw)
To: Ingo Oeser; +Cc: David S. Miller, netdev, linux-hams
On Mon, Sep 12, 2005 at 06:41:53PM +0200, Ingo Oeser wrote:
> That would not break backward compatibility and now the state machine can be
> self explanatory :-)
The states named by numbers are actually being used in the protocol spec.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-09-12 16:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-11 22:19 [PATCH 5/12] Add descriptions to constants Ralf Baechle DL5RB
2005-09-12 16:41 ` Ingo Oeser
2005-09-12 16:50 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).