From: "David S. Miller" <davem@davemloft.net>
To: akpm@osdl.org
Cc: fmalita@gmail.com, linux-kernel@vger.kernel.org,
ctindel@users.sourceforge.net, fubar@us.ibm.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] bond_main.c: fix device deregistration in init exception path
Date: Sun, 18 Sep 2005 00:25:48 -0700 (PDT) [thread overview]
Message-ID: <20050918.002548.92592728.davem@davemloft.net> (raw)
In-Reply-To: <20050917233224.2d4b3652.akpm@osdl.org>
From: Andrew Morton <akpm@osdl.org>
Date: Sat, 17 Sep 2005 23:32:24 -0700
> The fix is solid enough, although a better comment is needed. Let's
> let Dave decide whether that was a sane thing to go BUG over..
The fix is fine and so is the BUG() check.
Usually, you're supposed to make sure that the very last thing
you do is register_netdev(), and that all possible errors are
possible only before that call.
And that's what BOND basically does, except that it must register
multiple devices in a loop and therefore cannot follow that rule
precisely.
So I've added the patch to my tree, it's fine to do this for a
special case usage like this one.
next prev parent reply other threads:[~2005-09-18 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <432D0612.7070408@gmail.com>
2005-09-18 6:32 ` [PATCH] bond_main.c: fix device deregistration in init exception path Andrew Morton
2005-09-18 7:25 ` David S. Miller [this message]
2005-09-22 2:38 ` Jeff Garzik
2005-09-22 2:42 ` Andrew Morton
2005-09-22 2:43 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050918.002548.92592728.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=ctindel@users.sourceforge.net \
--cc=fmalita@gmail.com \
--cc=fubar@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).