From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch] fix suspend/resume on b44 Date: Wed, 21 Sep 2005 03:36:53 -0700 Message-ID: <20050921033653.05c448df.akpm@osdl.org> References: <20050920132811.GA4563@elf.ucw.cz> <20050920162635.565e4b46.akpm@osdl.org> <20050921102054.GE25297@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: jgarzik@pobox.com, netdev@oss.sgi.com Return-path: To: Pavel Machek In-Reply-To: <20050921102054.GE25297@atrey.karlin.mff.cuni.cz> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org Pavel Machek wrote: > > Hi! > > > > diff --git a/drivers/net/b44.c b/drivers/net/b44.c > > > --- a/drivers/net/b44.c > > > +++ b/drivers/net/b44.c > > > @@ -1930,6 +1930,8 @@ static int b44_suspend(struct pci_dev *p > > > b44_free_rings(bp); > > > > > > spin_unlock_irq(&bp->lock); > > > + > > > + free_irq(dev->irq, dev); > > > pci_disable_device(pdev); > > > return 0; > > > } > > > @@ -1946,6 +1948,9 @@ static int b44_resume(struct pci_dev *pd > > > if (!netif_running(dev)) > > > return 0; > > > > > > + if (request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev)) > > > + printk(KERN_ERR PFX "%s: request_irq failed\n", dev->name); > > > + > > > spin_lock_irq(&bp->lock); > > > > > > b44_init_rings(bp); > > > > > > > Why does it hang on suspend/resume? > > > > This came up a while back and iirc we decided that adding free_irq() to > > every ->suspend() handler in the world was the wrong thing to do. Do I > > misremember? > > No, you remember right, but b44 needed that free_irq/request_irq even > because those ACPI changes. I'm not exactly sure why, something went > very wrong otherwise. Well I guess we should work out what went wrong ;) What are the symptoms? Screaming interrupt? Can't immediately see why. Does the screaming interrupt detetor trigger and disable the IRQ Line?