From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] bond_main.c: fix device deregistration in init
 exception path
Date: Wed, 21 Sep 2005 19:42:05 -0700
Message-ID: <20050921194205.309695a7.akpm@osdl.org>
References: <432D0612.7070408@gmail.com>
	<20050917233224.2d4b3652.akpm@osdl.org>
	<43321922.70707@pobox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: fmalita@gmail.com, linux-kernel@vger.kernel.org,
	ctindel@users.sourceforge.net, fubar@us.ibm.com,
	davem@davemloft.net, netdev@vger.kernel.org
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S965226AbVIVCqJ@vger.kernel.org>
To: Jeff Garzik <jgarzik@pobox.com>
In-Reply-To: <43321922.70707@pobox.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Andrew Morton wrote:
> > diff -puN drivers/net/bonding/bond_main.c~bond_mainc-fix-device-deregistration-in-init-exception drivers/net/bonding/bond_main.c
> > --- devel/drivers/net/bonding/bond_main.c~bond_mainc-fix-device-deregistration-in-init-exception	2005-09-17 23:18:38.000000000 -0700
> > +++ devel-akpm/drivers/net/bonding/bond_main.c	2005-09-17 23:31:02.000000000 -0700
> > @@ -5039,6 +5039,14 @@ static int __init bonding_init(void)
> >  	return 0;
> >  
> >  out_err:
> > +	/*
> > +	 * rtnl_unlock() will run netdev_run_todo(), putting the
> > +	 * thus-far-registered bonding devices into a state which
> > +	 * unregigister_netdevice() will accept
> > +	 */
> > +	rtnl_unlock();
> > +	rtnl_lock();
> > +
> 
> 
> Don't we want a schedule() or schedule_timeout(1) in between?
> 

No, it's all synchronous.  See the nice comment ;)